Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(Core): Shaman Totems should not receive Raid/Party Wide Auras #20334

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+16 −0
Open

Fix(Core): Shaman Totems should not receive Raid/Party Wide Auras #20334

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a9fe3b6
Fix(Core): Shaman Totems should not receive Raid/Party Wide Auras
IntelligentQuantum Oct 29, 2024
a9114bb
Update Unit.cpp
IntelligentQuantum Nov 3, 2024
8bdd520
.
IntelligentQuantum Nov 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions src/server/game/Entities/Unit/Unit.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4506,6 +4506,22 @@ void Unit::_ApplyAura(AuraApplication* aurApp, uint8 effMask)
{
Aura* aura = aurApp->GetBase();

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be made more readable? It’s not very easy to read as it is. What does critter have to do with totem though?

Copy link
Member

@Nyeriah Nyeriah Nov 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also won’t this block totems from receiving any aura? What about stoneclaw totem?

if (IsTotem() && aura->GetCaster() != this)
{
if (aura->GetSpellInfo()->Id != 55277)
return;
}
else if (GetCreatureType() == CREATURE_TYPE_CRITTER)
{
if (aura->GetSpellInfo()->Id != 55277)
return;
}
else if (IsPet() && !IsInCombat())
{
if (aura->GetSpellInfo()->Id != 55277)
return;
}

_RemoveNoStackAurasDueToAura(aura);

if (aurApp->GetRemoveMode())
Expand Down