Add more tests (#1)

* test: add more tests for no-relative-import

* test: add tests for getPackages()

src/rules/no-relative-import.js

@@ -26,21 +26,21 @@ export const create = context => {
     }
 
     const pkg = packages.find(pkg => isInside(resolvedPath, pkg.fsPath));
-    if (pkg) {
-      const subPackagePath = path.relative(pkg.fsPath, resolvedPath);
-      context.report({
-        node,
-        message: `Import for monorepo package '${
-          pkg.name
-        }' should be absolute.`,
-        fix: fixer => {
-          fixer.replaceText(
-            node,
-            `${pkg.name}${subPackagePath !== '.' ? '/' + subPackagePath : ''}`
-          );
-        },
-      });
+    if (!pkg) {
+      return;
     }
+
+    const subPackagePath = path.relative(pkg.fsPath, resolvedPath);
+    context.report({
+      node,
+      message: `Import for monorepo package '${pkg.name}' should be absolute.`,
+      fix: fixer => {
+        fixer.replaceText(
+          node,
+          `${pkg.name}${subPackagePath !== '.' ? '/' + subPackagePath : ''}`
+        );
+      },
+    });
   }, moduleUtilOptions);
 };
 

test/__snapshots__/get-packages.test.js.snap

@@ -0,0 +1,27 @@
+// Jest Snapshot v1, https://goo.gl/fbAQLP
+
+exports[`getPackages() lerna matches snapshot 1`] = `
+Array [
+  Object {
+    "fsPath": "<cwd>/test/fixture/lerna/packages/bar",
+    "name": "bar",
+  },
+  Object {
+    "fsPath": "<cwd>/test/fixture/lerna/packages/foo",
+    "name": "foo",
+  },
+]
+`;
+
+exports[`getPackages() yarn matches snapshot 1`] = `
+Array [
+  Object {
+    "fsPath": "<cwd>/test/fixture/yarn/packages/bar",
+    "name": "bar",
+  },
+  Object {
+    "fsPath": "<cwd>/test/fixture/yarn/packages/foo",
+    "name": "foo",
+  },
+]
+`;

test/fixture/lerna/lerna.json

@@ -0,0 +1,3 @@
+{
+  "packages": ["packages/*"]
+}

test/fixture/lerna/packages/bar/package.json

@@ -0,0 +1,3 @@
+{
+  "name": "bar"
+}

test/fixture/lerna/packages/foo/package.json

@@ -0,0 +1,3 @@
+{
+  "name": "foo"
+}

test/get-packages.test.js

@@ -0,0 +1,23 @@
+import getPackages from '../src/get-packages';
+import path from 'path';
+
+const LERNA_DIR = path.join(__dirname, 'fixture/lerna');
+const YARN_DIR = path.join(__dirname, 'fixture/yarn');
+
+expect.addSnapshotSerializer({
+  test: value =>
+    typeof value === 'string' &&
+    (value.indexOf('\\') > -1 || value.indexOf(process.cwd()) > -1),
+  print: (value, serializer) =>
+    serializer(value.replace(process.cwd(), '<cwd>').replace(/\\/g, '/')),
+});
+
+describe('getPackages()', () => {
+  test('lerna matches snapshot', () => {
+    expect(getPackages(LERNA_DIR)).toMatchSnapshot();
+  });
+
+  test('yarn matches snapshot', () => {
+    expect(getPackages(YARN_DIR)).toMatchSnapshot();
+  });
+});

test/rules/no-internal-import.test.js

@@ -3,6 +3,7 @@ import path from 'path';
 import * as monorepo from '../../src';
 
 const RULE = 'no-internal-import';
+const ERROR = { message: `Import for monorepo package 'foo' is internal.` };
 const fixtures = path.join(__dirname, '../fixture/yarn');
 
 process.cwd = jest.fn(() => fixtures);
@@ -23,7 +24,7 @@ ruleTester.run(RULE, monorepo.rules[RULE], {
     {
       code: `import pkg from 'foo/src/pkg'`,
       filename: path.join(fixtures, 'packages/bar/index.js'),
-      errors: [{ message: `Import for monorepo package 'foo' is internal.` }],
+      errors: [ERROR],
     },
   ],
 });

test/rules/no-relative-import.test.js

@@ -3,6 +3,9 @@ import path from 'path';
 import * as monorepo from '../../src';
 
 const RULE = 'no-relative-import';
+const ERROR = {
+  message: `Import for monorepo package 'foo' should be absolute.`,
+};
 const fixtures = path.join(__dirname, '../fixture/yarn');
 
 process.cwd = jest.fn(() => fixtures);
@@ -17,15 +20,35 @@ ruleTester.run(RULE, monorepo.rules[RULE], {
       code: `import foo from 'foo'`,
       filename: path.join(fixtures, 'packages/bar/index.js'),
     },
+    {
+      code: `const foo = require('foo')`,
+      filename: path.join(fixtures, 'packages/bar/index.js'),
+      options: [{ commonjs: true }],
+    },
+    {
+      code: `define(['foo'], factory)`,
+      filename: path.join(fixtures, 'packages/bar/index.js'),
+      options: [{ amd: true }],
+    },
   ],
 
   invalid: [
     {
       code: `import foo from '../foo'`,
       filename: path.join(fixtures, 'packages/bar/index.js'),
-      errors: [
-        { message: `Import for monorepo package 'foo' should be absolute.` },
-      ],
+      errors: [ERROR],
+    },
+    {
+      code: `const foo = require('../foo')`,
+      filename: path.join(fixtures, 'packages/bar/index.js'),
+      options: [{ commonjs: true }],
+      errors: [ERROR],
+    },
+    {
+      code: `define(['../foo'], factory)`,
+      filename: path.join(fixtures, 'packages/bar/index.js'),
+      options: [{ amd: true }],
+      errors: [ERROR],
     },
   ],
 });