Header and minor ui changes #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acrantel
requested changes
Jun 25, 2023
acrantel
reviewed
Jun 25, 2023
acrantel
force-pushed
the
frontend2
branch
2 times, most recently
from
8a352d3
to
1e17ddf
Compare
apollo1291
force-pushed
the
basecard-header
branch
from
4507804
to
a69230f
Compare
acrantel
reviewed
Aug 20, 2023
acrantel
previously requested changes
Aug 20, 2023
There was a problem hiding this comment.
thanks for tackling this! headers are super complicated
I put this in comments but wanted to mention it here; images should live in the frontend2/public directory. When you want to reference it in code, you just need to use /<image_name_with_extension> to display it
Also please make sure to run npm run format so that your code is formatted :)
acrantel
force-pushed
the
basecard-header
branch
from
a69230f
to
79631f8
Compare
consistency responsive header update header remove chatgpt comments
acrantel
force-pushed
the
basecard-header
branch
from
79631f8
to
ab1a26e
Compare
acrantel
force-pushed
the
basecard-header
branch
from
631db21
to
50ba18a
Compare
Closed
acrantel
added a commit
that referenced
this pull request
Oct 3, 2023
Co-authored-by: Serena Li <serena.li.usa@gmail.com>
acrantel
added a commit
that referenced
this pull request
Feb 8, 2024
Co-authored-by: Serena Li <serena.li.usa@gmail.com>
acrantel
added a commit
that referenced
this pull request
Feb 8, 2024
Co-authored-by: Serena Li <serena.li.usa@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the Header component (nav bar at the top of the page)
Note: we don't automatically generate profile pictures for new accounts, so the alt text shows in the image below. We should either generate this in the backend (#327 has some work on this), or display a default profile picture. I've added this onto our roadmap
Testing:
Log inoption at the bottom of the dropdown.Your profile, andSign outLog inandRegisterbutton in the right side of the header. TheLog inbutton will disappear at small window widths.