Sidebar2 #668
Closed
Sidebar2 #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acrantel
requested changes
Aug 20, 2023
| @@ -24,7 +24,7 @@ const Sidebar: React.FC<SidebarProps> = ({ collapsed }) => { | |||
| const linkBase = `/${episodeId}/`; | |||
|
|
|||
| return collapsed ? null : ( | |||
| <div className="flex flex-col gap-8 py-4 h-full bg-gray-50 shadow-gray-200 shadow-sm"> | |||
| <div className="flex flex-col gap-8 py-4 h-full bg-gray-50 shadow-gray-200 shadow-sm hidden sm:block"> | |||
There was a problem hiding this comment.
This div should have display=flex on screens larger than 640px, not displayblock. Adding sm:block makes the div have display=block on screens larger than the sm breakpoint (640px).
we should change this className to be:
"hidden sm:flex flex-col gap-8 py-4 h-full bg-gray-50 shadow-gray-200 shadow-sm"
here's a useful link to understand how style using breakpoints: https://tailwindcss.com/docs/responsive-design#targeting-mobile-screens
|
superseded by #654 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.