Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidebar2 #668

Closed
wants to merge 1 commit into from
Closed

Sidebar2 #668

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend2/src/components/sidebar/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ const Sidebar: React.FC<SidebarProps> = ({ collapsed }) => {
const linkBase = `/${episodeId}/`;

return collapsed ? null : (
<div className="flex flex-col gap-8 py-4 h-full bg-gray-50 shadow-gray-200 shadow-sm">
<div className="flex flex-col gap-8 py-4 h-full bg-gray-50 shadow-gray-200 shadow-sm hidden sm:block">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This div should have display=flex on screens larger than 640px, not displayblock. Adding sm:block makes the div have display=block on screens larger than the sm breakpoint (640px).

we should change this className to be:
"hidden sm:flex flex-col gap-8 py-4 h-full bg-gray-50 shadow-gray-200 shadow-sm"

here's a useful link to understand how style using breakpoints: https://tailwindcss.com/docs/responsive-design#targeting-mobile-screens

<SidebarSection title="">
<SidebarItem
icon={<HomeIcon className="h-6 w-6" />}
Expand Down