Api Cleanup #664
Merged
Api Cleanup #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
halp @acrantel my lint seems to be broken😢 |
acrantel
requested changes
Aug 13, 2023
There was a problem hiding this comment.
thanks for doing this!
what command did you run that formatted all the autogenerated files? if it was npm run format or lint then we'll need to update the ignores in eslintrc.js and .prettierignore . it should be fairly straightforward, just put the path to the autogenerated folder in the ignore lists
we shouldn't commit the format changes to the autogenerated files, here is a stackoverflow solution for how to remove them from your pr: https://stackoverflow.com/a/39460058
acrantel
reviewed
Aug 14, 2023
acrantel
pushed a commit
that referenced
this pull request
Aug 15, 2023
Use functions for api, not static class methods 👍
acrantel
pushed a commit
that referenced
this pull request
Aug 15, 2023
Use functions for api, not static class methods 👍
acrantel
pushed a commit
that referenced
this pull request
Oct 3, 2023
Use functions for api, not static class methods 👍
acrantel
pushed a commit
that referenced
this pull request
Feb 8, 2024
Use functions for api, not static class methods 👍
acrantel
pushed a commit
that referenced
this pull request
Feb 8, 2024
Use functions for api, not static class methods 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀