24667 - fix missing body for filing when bootstrap business #108
Conversation
…n bootsrap business.
hfekete
requested review from
BrandonSharratt,
severinbeauvais and
patrickpeinanw
|
for proper test, needs validate PR in first |
|
/gcbrun |
|
Temporary Url for review: https://business-dashboard-dev--pr-108-z69vntif.web.app SB says, try these:
|
| const businessIdentifier = filing.businessIdentifier | ||
| const url = new URL(window.location.href) | ||
| url.pathname = `/${businessIdentifier}` | ||
| window.location.assign(url.toString()) |
There was a problem hiding this comment.
How can I test this?
There was a problem hiding this comment.
waiting for Patricks PR to get merged in
|
IA test result:
|
|
/gcbrun |
|
Temporary Url for review: https://business-dashboard-dev--pr-108-z69vntif.web.app |
|
/gcbrun |
|
Temporary Url for review: https://business-dashboard-dev--pr-108-z69vntif.web.app |
|
/gcbrun |
|
Temporary Url for review: https://business-dashboard-dev--pr-108-z69vntif.web.app |
|
Continuation-in example (thank you Patrick !!) https://business-dashboard-dev--pr-108-z69vntif.web.app/TTk5dZdqlE |
|
The screenshots look good but not perfect. If you have time, check the whitespace below the button and the divider. |
*Issue:24667 *bcgov/entity#24667
Description of changes:
fix issue when no body shown for bootstrap filing when filing is completed (on bootstrap business screen)
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).