-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
24667 - fix missing body for filing when bootstrap business #108
Merged
Merged
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a6442b7
24817 - fix: wrong redirect; missing start date for filngs.
hfekete a583855
Merge branch 'main' of github.com:bcgov/business-dashboard-ui
hfekete 05d0f8f
chore: remove comment.
hfekete e28df88
24667 - fix missing body for retrieve business information button whe…
hfekete 8c20765
Merge branch 'main' of github.com:bcgov/business-dashboard-ui
hfekete af9d462
fix: eslint
hfekete 474cba1
Merge branch 'main' of github.com:bcgov/business-dashboard-ui
hfekete 3faf61d
fix: lang texts.
hfekete 4407c0c
fix: boostrapName missing.
hfekete 4c4ba2e
fix: cleanup log out.
hfekete File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,9 @@ | ||
/** Reloads Filings UI using business id instead of temporary registration number. */ | ||
export const reloadWithBusinessId = () => { | ||
export const reloadWithBusinessId = (filing: ApiResponseFilingI) => { | ||
// build the URL to the business dashboard with the business id and any URL parameters | ||
// const url = getDashboardUrl + filing.businessIdentifier // + this.$route.fullPath | ||
const url = window.location.href | ||
window.location.assign(url) | ||
const businessIdentifier = filing.businessIdentifier | ||
const url = new URL(window.location.href) | ||
url.pathname = `/${businessIdentifier}` | ||
window.location.assign(url.toString()) | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can I test this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
waiting for Patricks PR to get merged in