Chore 456 operation representative #2688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayeshmcg
force-pushed
the
chore-456-operation-representative
branch
from
20ac6b6 to
1b125c2
Compare
shon-button
reviewed
Jan 15, 2025
bc_obps/registration/tests/endpoints/v1/user/test_user_profile.py
Outdated
Show resolved
Hide resolved
bc_obps/registration/tests/endpoints/v2/user/test_user_profile.py
Outdated
Show resolved
Hide resolved
ayeshmcg
force-pushed
the
chore-456-operation-representative
branch
from
1b125c2 to
da22a12
Compare
shon-button
approved these changes
Jan 15, 2025
pbastia
requested changes
Jan 15, 2025
| fields = ["id", "representative_name", "selected_for_report"] | ||
|
|
||
|
|
||
| class ReportOperationSchemaOut(Schema): |
There was a problem hiding this comment.
Instead of creating a whole extra ReportOperationSchemaOut class, we could extend the existing ReportOperationOut and add the report_operation_representatives: List[...] field on it
pbastia
approved these changes
Jan 16, 2025
ayeshmcg
force-pushed
the
chore-456-operation-representative
branch
from
c2a5775 to
319edcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Card: bcgov/cas-reporting#456
Changes: