Morecast: Validation on editable fields

[conbrad]

Adds an optional validator function for IndeterminateField that gets called in preProcessEditCellProps callback for cells in edit mode to set the error prop if validation doesn't pass for the forecast parameter. The same validator function is passed down to cells in view mode to do the same thing.

Adds the EditInputCell component as the render component for cells in edit mode that gets rendered by the renderEditCell callback on the GridColDef. EditInputCell props include an empty or non-empty error string that drives the visibility of the tooltip and red border.

Similar behaviour for the renderCell callback for cells in view mode, except it doesn't receive the error string in props so it calls validator itself. This is to keep the same behaviour whether the user is actively editing or not and the current value is invalid.

Opted to prevent edits from committing locally when invalid so that invalid values aren't stored in drafts.

Closes #3571

Test Links:

Landing Page
MoreCast
Percentile Calculator
C-Haines
FireBat
FireBat bookmark
Auto Spatial Advisory (ASA)
HFI Calculator

[codecov]

Codecov Report

Attention: Patch coverage is 91.13924% with 7 lines in your changes missing coverage. Please review.

Project coverage is 81.35%. Comparing base (b7d7bc0) to head (d54cfa1).

Files with missing lines	Patch %	Lines
...features/moreCast2/components/ColumnDefBuilder.tsx	55.55%	4 Missing ⚠️
.../features/moreCast2/components/MoreCast2Column.tsx	89.47%	1 Missing and 1 partial ⚠️
...b/src/features/moreCast2/slices/validInputSlice.ts	80.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3919      +/-   ##
==========================================
+ Coverage   81.31%   81.35%   +0.04%     
==========================================
  Files         294      298       +4     
  Lines       11362    11421      +59     
  Branches      526      546      +20     
==========================================
+ Hits         9239     9292      +53     
- Misses       2089     2094       +5     
- Partials       34       35       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dgboss]

Could we get rid of the new blue border when editing a cell?

[dgboss]

It's looking really good!
I noticed that validation errors/tooltip doesn't persist when you go from the weather parameter tabs to the Forecast Summary tab. Realistically this probably isn't an issue as I would expect a forecaster to correct validation errors as they enter them.

[dgboss]

Oh, should we add validation for the grass curing fields as well?

[conbrad]

It's looking really good! I noticed that validation errors/tooltip doesn't persist when you go from the weather parameter tabs to the Forecast Summary tab. Realistically this probably isn't an issue as I would expect a forecaster to correct validation errors as they enter them.

It's looking really good! I noticed that validation errors/tooltip doesn't persist when you go from the weather parameter tabs to the Forecast Summary tab. Realistically this probably isn't an issue as I would expect a forecaster to correct validation errors as they enter them.

Nice catch! I adjusted the code to share the validation logic between edit and view mode cells: 59a301e

[brettedw]

Looks great, nice work! Only comment would be same as Darren's

Oh, should we add validation for the grass curing fields as well?

[brettedw]

Just noticed there's a number of code smells. Unused imports in a few cases, otherwise just complaining about using optional chain expressions. I'm fine either way

[conbrad]

Just noticed there's a number of code smells. Unused imports in a few cases, otherwise just complaining about using optional chain expressions. I'm fine either way

Thanks fixed, part of it was a bunch of duplicated code between forecast and grass cure cells that I deduped in a shared ValidatedForecastCell component.

[brettedw]

Looks great to me! Nice work!

[dgboss]

This is great! Only one tiny nit that could be addressed in a followup PR. The tooltip position becomes a little wonky when toggling between the Forecast Summary tab and the other tabs. Definitely not worth holding up the PR for.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud