Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Morecast: Validation on editable fields #3919

Merged
merged 23 commits into from
Sep 16, 2024
Merged

Morecast: Validation on editable fields #3919

merged 23 commits into from
Sep 16, 2024

Commits on Sep 11, 2024

  1. Validation on editable fields

    @conbrad
    conbrad committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    7efee9c View commit details
    Browse the repository at this point in the history

  2. Undo unnecessary change

    @conbrad
    conbrad committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    ff8b983 View commit details
    Browse the repository at this point in the history

  3. Remove comments

    @conbrad
    conbrad committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    4ed4c4f View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. More explicit messages

    @conbrad
    conbrad committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    b94d27f View commit details
    Browse the repository at this point in the history

  2. Force user to fix issue

    @conbrad
    conbrad committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    5086748 View commit details
    Browse the repository at this point in the history

  3. Make error a string always

    @conbrad
    conbrad committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    6228942 View commit details
    Browse the repository at this point in the history

  4. Add more tests, disable publish button when invalid

    @conbrad
    conbrad committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    2d6f062 View commit details
    Browse the repository at this point in the history

  5. Logic tests

    @conbrad
    conbrad committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    8248ea2 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into task/validate-editing-feedback

    @conbrad
    conbrad authored Sep 12, 2024
    Configuration menu
    Copy the full SHA
    397725b View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into task/validate-editing-feedback

    @conbrad
    conbrad authored Sep 12, 2024
    Configuration menu
    Copy the full SHA
    09ecabc View commit details
    Browse the repository at this point in the history

  8. Update web/src/features/moreCast2/components/editInputCell.test.tsx 

    Co-authored-by: dgboss <darren.boss@gov.bc.ca>
    @conbrad @dgboss
    conbrad and dgboss authored Sep 12, 2024
    Configuration menu
    Copy the full SHA
    04348f3 View commit details
    Browse the repository at this point in the history

  9. Feedback

    @conbrad
    conbrad committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    2d168d4 View commit details
    Browse the repository at this point in the history

  10. Add semi-colon back

    @conbrad
    conbrad committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    7fd7cc4 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. Use validation logic across editing and view cells

    @conbrad
    conbrad committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    59a301e View commit details
    Browse the repository at this point in the history

  2. Add forecast cell tests

    @conbrad
    conbrad committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    9bacab7 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Add grass curing validation logic

    @conbrad
    conbrad committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    7a7b3b6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into task/validate-editing-feedback

    @conbrad
    conbrad committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    3b651c4 View commit details
    Browse the repository at this point in the history

  3. Grass curing validation component

    @conbrad
    conbrad committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    4276152 View commit details
    Browse the repository at this point in the history

  4. unused imports

    @conbrad
    conbrad committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    7566499 View commit details
    Browse the repository at this point in the history

  5. Dedup code across forecast and grass cure forecast cells

    @conbrad
    conbrad committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    78887c5 View commit details
    Browse the repository at this point in the history

  6. Remove unused code

    @conbrad
    conbrad committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    ae537c7 View commit details
    Browse the repository at this point in the history

  7. unused error

    @conbrad
    conbrad committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    750b4f1 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into task/validate-editing-feedback

    @conbrad
    conbrad authored Sep 16, 2024
    Configuration menu
    Copy the full SHA
    d54cfa1 View commit details
    Browse the repository at this point in the history