Allow UTF-8 printable chars , not just ASCII#78
Open
a-luna wants to merge 2 commits intobchao1:masterfrom
Open
Allow UTF-8 printable chars , not just ASCII#78a-luna wants to merge 2 commits intobchao1:masterfrom
a-luna wants to merge 2 commits intobchao1:masterfrom
Conversation
|
Can you review @bchao1 ? Chars that still not works for me:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if a user provides a non-ASCII, UTF-8 printable character (e.g., any of the following:
äüöëñ0¡¢漢字♀♂) to anInputprompt, the prompt immediately exits and returnsNonein place of the non-ASCII character.This PR adds a new function to
utils.py, based on a stackoverflow response (Test if a python string is printable):A call to the
is_printablefunction replaces the line ingetcharthat checks if each character exists instring.printable:Here's an example of the new behavior:
Example
Output
Closes #76