Skip to content

Allow UTF-8 printable chars , not just ASCII #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
a-luna wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow UTF-8 printable chars , not just ASCII #78

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e82ea26
Allow UTF-8 printable chars , not just ASCII
a-luna Feb 6, 2021
000bf60
Refactor is_printable to be more elegant.
a-luna Feb 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion bullet/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def getchar():
return getchar()

else:
if c in string.printable:
if is_printable(c):
return c
else:
return UNDEFINED_KEY
Expand Down Expand Up @@ -117,3 +117,14 @@ def cprint(
None
'''
forceWrite(on + color + s + colors.RESET, end = end)

def is_printable(s: str) -> bool:
"""Determine if a string contains only printable characters.
Args:
s: The string to verify.
Returns:
bool: `True` if all characters in `s` are printable. `False` if any
characters in `s` can not be printed.
"""
# Ref: https://stackoverflow.com/a/50731077
return not any(repr(ch).startswith(("'\\x", "'\\u")) for ch in s)