Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bondcpp dependency to install_spot_ros2.sh #615

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

khughes-bdai
Copy link
Collaborator

@khughes-bdai khughes-bdai commented Mar 6, 2025

Change Overview

Noticed when running code locally that my colcon builds were failing because I was missing the bondcpp dependency added recently. This adds it to the install script

Testing Done

Ran script locally

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Collaborator

@mhidalgo-bdai mhidalgo-bdai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Using rosdep install would free us though from having to keep track of these in addition to listing them in package.xml files.

Copy link
Collaborator Author

khughes-bdai commented Mar 6, 2025

Merge activity

  • Mar 6, 12:32 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Mar 6, 12:33 PM EST: Graphite rebased this pull request as part of a merge.
  • Mar 6, 12:50 PM EST: A user merged this pull request with Graphite.

Signed-off-by: Katie Hughes <khughes-bdai@theaiinstitute.com>
@khughes-bdai khughes-bdai force-pushed the khughes/bondcpp-install-script branch from 80313c5 to e71ffbd Compare March 6, 2025 17:33
@khughes-bdai khughes-bdai merged commit eed9f44 into main Mar 6, 2025
5 checks passed
@khughes-bdai khughes-bdai deleted the khughes/bondcpp-install-script branch March 6, 2025 17:50
@coveralls
Copy link

coveralls commented Mar 6, 2025

Pull Request Test Coverage Report for Build 13703845286

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.372%

Totals Coverage Status
Change from base Build 13703775617: 0.0%
Covered Lines: 2059
Relevant Lines: 4008

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants