Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With gc disabled deletion of class X causes it to "leak" to garbage #176

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Mephius
Copy link

@Mephius Mephius commented Feb 9, 2017

No description provided.

@benjaminp
Copy link
Owner

Can you be more specific about what the problem is? X shows up in gc.garbage? I'm not sure this is a usecase we care much about.

@Mephius
Copy link
Author

Mephius commented Mar 1, 2017

Yes, it goes to gc.garbage. Since we run our environment with gc disabled we monitor garbage during development to make sure we don't leak anything. This causes our automated alert to trigger.
I agree that this is the case that no one cares about, but the change is trivial, doesn't hurt anyone and will save us some time while upgrading the library.

Thanks.

@jeffwidman
Copy link

@benjaminp any update here?

jeffwidman added a commit to dpkp/kafka-python that referenced this pull request Oct 22, 2018
Bump `six` to `1.11.0`. Most changes do not affect us, but it's good to
stay up to date. Also, we will likely start vendoring `enum34` in which
case benjaminp/six#178 is needed.

Note that this preserves the `kafka-python` customization from #979
which has been submitted upstream as benjaminp/six#176 but not yet merged.
jeffwidman added a commit to dpkp/kafka-python that referenced this pull request Oct 22, 2018
Bump `six` to `1.11.0`. Most changes do not affect us, but it's good to
stay up to date. Also, we will likely start vendoring `enum34` in which
case benjaminp/six#178 is needed.

Note that this preserves the `kafka-python` customization from #979
which has been submitted upstream as benjaminp/six#176 but not yet merged.
jeffwidman added a commit to dpkp/kafka-python that referenced this pull request Oct 22, 2018
Bump `six` to `1.11.0`. Most changes do not affect us, but it's good to
stay up to date. Also, we will likely start vendoring `enum34` in which
case benjaminp/six#178 is needed.

Note that this preserves the `kafka-python` customization from #979
which has been submitted upstream as benjaminp/six#176 but not yet merged.
@nicktimko
Copy link

To avoid a six.X popping up as a "public" thing if you removed del X, you could rename class X to something like class _OverflowProbe.

shifqu added a commit to shifqu/kafka-python that referenced this pull request Sep 28, 2023
In this commit, the del X is still commented out due to the fact that upstream benjaminp/six#176 is not merged.
wbarnha pushed a commit to dpkp/kafka-python that referenced this pull request Nov 2, 2023
In this commit, the del X is still commented out due to the fact that upstream benjaminp/six#176 is not merged.
jjaakola-aiven pushed a commit to aiven/kafka-python that referenced this pull request May 13, 2024
In this commit, the del X is still commented out due to the fact that upstream benjaminp/six#176 is not merged.
jjaakola-aiven pushed a commit to aiven/kafka-python that referenced this pull request May 13, 2024
In this commit, the del X is still commented out due to the fact that upstream benjaminp/six#176 is not merged.
bradenneal1 pushed a commit to bradenneal1/kafka-python that referenced this pull request May 16, 2024
In this commit, the del X is still commented out due to the fact that upstream benjaminp/six#176 is not merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants