warning: unneeded `return` statement --> src/main.rs:192:37 | 192 | Event::LoopDestroyed => return, | ^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return help: replace `return` with a unit value | 192 | Event::LoopDestroyed => (), | ~~

warning: casting integer literal to `u16` is unnecessary --> src/main.rs:155:54 | 155 | let x = 1.0f32 * f32::from(counter % 7 as u16); | ^^^^^^^^ help: try: `7_u16` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast = note: `#[warn(clippy::unnecessary_cast)]` on by default

warning: unneeded `return` statement --> src/support/mod.rs:155:5 | 155 | return dir; | ^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `#[warn(clippy::needless_return)]` on by default help: remove `return` | 155 - return dir; 155 + dir |

warning: this operation has no effect --> src/support/texture.rs:149:41 | 149 | data.push(self.data[(i * self.unit_bytes + 0) as usize]); // R | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `i * self.unit_bytes` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op

warning: this operation has no effect --> src/support/texture.rs:141:41 | 141 | data.push(self.data[(i * self.unit_bytes + 0) as usize]); // R | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `i * self.unit_bytes` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op

warning: this operation has no effect --> src/support/texture.rs:93:26 | 93 | [(self.data[i as usize] as u32 * palette.unit_bytes + 0) as usize], | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `self.data[i as usize] as u32 * palette.unit_bytes` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op

warning: this operation has no effect --> src/support/resource.rs:266:32 | 266 | params[row * 3 + 0], | ^^^^^^^^^^^ help: consider reducing it to: `row * 3` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op

warning: the loop variable `i` is only used to index `params` --> src/support/resource.rs:260:26 | 260 | for i in 0..12 { | ^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop help: consider using an iterator | 260 | for <item> in &mut params { | ~~~~~~ ~~~~~~~~~~~

warning: the loop variable `i` is only used to index `params` --> src/support/resource.rs:147:26 | 147 | for i in 0..12 { | ^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop help: consider using an iterator | 147 | for <item> in &mut params { | ~~~~~~ ~~~~~~~~~~~

warning: field assignment outside of initializer for an instance created with Default::default() --> src/support/resource.rs:32:9 | 32 | h.chunk_type = source.read_u32::<BigEndian>()?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | note: consider initializing the variable with `support::resource::ChunkHeader { chunk_type: source.read_u32::<BigEndian>()?, size: source.read_u32::<BigEndian>()? }` and removing relevant reassignments --> src/support/resource.rs:31:9 | 31 | let mut h = ChunkHeader::default(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default

warning: using `clone` on type `Matrix4<f32>` which implements the `Copy` trait --> src/support/render_manager.rs:256:36 | 256 | let model: [[f32; 4]; 4] = model.clone().into(); | ^^^^^^^^^^^^^ help: try dereferencing it: `(*model)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy = note: `#[warn(clippy::clone_on_copy)]` on by default

warning: this expression creates a reference which is immediately dereferenced by the compiler --> src/support/render_manager.rs:206:47 | 206 | self.draw_actor(name, &transform_stack.last().unwrap(), target, camera); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `transform_stack.last().unwrap()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: dereferencing a tuple pattern where every element takes a reference --> src/support/render_manager.rs:202:17 | 202 | &ActorNode::MeshfileRef(ref name) => { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference help: try removing the `&` and `ref` parts | 202 - &ActorNode::MeshfileRef(ref name) => { 202 + ActorNode::MeshfileRef(name) => { |

warning: you don't need to add `&` to all patterns --> src/support/render_manager.rs:185:13 | 185 | / match actor.data() { 186 | | &ActorNode::Actor { ref name, visible } => { 187 | | actor_name = name.clone(); 188 | | v = visible; ... | 225 | | _ => (), 226 | | } | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats = note: `#[warn(clippy::match_ref_pats)]` on by default help: instead of prefixing all patterns with `&`, you can dereference the expression | 185 ~ match *actor.data() { 186 ~ ActorNode::Actor { ref name, visible } => { 187 | actor_name = name.clone(); ... 201 | } 202 ~ ActorNode::MeshfileRef(ref name) => { 203 | debug_tree(&format!("Mesh {}", name), &actor_name, &transform_stack); ... 208 | } 209 ~ ActorNode::Transform(t) => { |

warning: this expression creates a reference which is immediately dereferenced by the compiler --> src/support/render_manager.rs:162:81 | 162 | IndexBuffer::new(display, PrimitiveType::TrianglesList, &item).unwrap(), | ^^^^^ help: change this to: `item` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: use of `or_insert` to construct default value --> src/support/render_manager.rs:140:18 | 140 | .or_insert(Vec::new()); | ^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default

warning: dereferencing a tuple pattern where every element takes a reference --> src/support/render_manager.rs:117:17 | 117 | &ActorNode::MeshfileRef(ref name) => { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference help: try removing the `&` and `ref` parts | 117 - &ActorNode::MeshfileRef(ref name) => { 117 + ActorNode::MeshfileRef(name) => { |

warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` --> src/support/render_manager.rs:116:13 | 116 | / match actor.data() { 117 | | &ActorNode::MeshfileRef(ref name) => { 118 | | debug!("Actor meshfile {}", name); 119 | | self.prepare_car_actor(name, car, display); 120 | | } 121 | | _ => (), 122 | | } | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match help: try | 116 ~ if let &ActorNode::MeshfileRef(ref name) = actor.data() { 117 + debug!("Actor meshfile {}", name); 118 + self.prepare_car_actor(name, car, display); 119 + } |

warning: use of `or_insert` to construct default value --> src/support/render_manager.rs:85:18 | 85 | .or_insert(HashMap::new()); | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default = note: `#[warn(clippy::unwrap_or_default)]` on by default

warning: you seem to want to iterate on a map's keys --> src/support/render_manager.rs:81:26 | 81 | for (&mat, _) in &self.indices[actor_name] { | ^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map help: use the corresponding method | 81 | for &mat in self.indices[actor_name].keys() { | ~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

warning: you seem to want to iterate on a map's keys --> src/support/render_manager.rs:58:33 | 58 | for (name, _indices) in &self.indices { | ^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map = note: `#[warn(clippy::for_kv_map)]` on by default help: use the corresponding method | 58 | for name in self.indices.keys() { | ~~~~ ~~~~~~~~~~~~~~~~~~~

warning: the loop variable `n` is used to index `uvcoords` --> src/support/mesh.rs:110:18 | 110 | for n in 0..uvcoords.len() { | ^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop help: consider using an iterator and enumerate() | 110 | for (n, <item>) in uvcoords.iter().enumerate() { | ~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~

warning: the loop variable `i` is used to index `fmlist` --> src/support/mesh.rs:105:22 | 105 | for i in 0..m.faces.len() { | ^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop = note: `#[warn(clippy::needless_range_loop)]` on by default help: consider using an iterator and enumerate() | 105 | for (i, <item>) in fmlist.iter().enumerate().take(m.faces.len()) { | ~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

warning: length comparison to zero --> src/support/mesh.rs:104:12 | 104 | if fmlist.len() > 0 && m.faces.len() == fmlist.len() { | ^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!fmlist.is_empty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero = note: `#[warn(clippy::len_zero)]` on by default

warning: field assignment outside of initializer for an instance created with Default::default() --> src/support/mesh.rs:47:9 | 47 | s.v1 = rdr.read_u16::<BigEndian>()?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | note: consider initializing the variable with `support::mesh::Face { v1: rdr.read_u16::<BigEndian>()?, v2: rdr.read_u16::<BigEndian>()?, v3: rdr.read_u16::<BigEndian>()?, flags: rdr.read_u16::<BigEndian>()?, ..Default::default() }` and removing relevant reassignments --> src/support/mesh.rs:46:9 | 46 | let mut s = Face::default(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default

warning: field assignment outside of initializer for an instance created with Default::default() --> src/support/mesh.rs:29:9 | 29 | uv.u = rdr.read_f32::<BigEndian>()?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | note: consider initializing the variable with `support::mesh::UvCoord { u: rdr.read_f32::<BigEndian>()?, v: rdr.read_f32::<BigEndian>()? }` and removing relevant reassignments --> src/support/mesh.rs:28:9 | 28 | let mut uv = UvCoord::default(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default = note: `#[warn(clippy::field_reassign_with_default)]` on by default

warning: this expression creates a reference which is immediately dereferenced by the compiler --> src/support/car.rs:612:43 | 612 | let pmap = pmap.remap_via(&palette)?; | ^^^^^^^^ help: change this to: `palette` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> src/support/car.rs:602:60 | 602 | let pix_file_name = path_subst(&pix_file_name, &Path::new("PIXELMAP"), None); | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `Path::new("PIXELMAP")` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this operation has no effect --> src/support/car.rs:591:30 | 591 | palette.data[(x * palette.unit_bytes + 0) as usize] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider reducing it to: `x * palette.unit_bytes` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op = note: `#[warn(clippy::identity_op)]` on by default

warning: this expression creates a reference which is immediately dereferenced by the compiler --> src/support/car.rs:583:56 | 583 | let pal_file_name = path_subst(&pal_file_name, &Path::new("REG/PALETTES"), None); | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `Path::new("REG/PALETTES")` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: you are using an explicit closure for cloning elements --> src/support/car.rs:563:13 | 563 | load_materials.iter().map(|s| s.clone()).collect(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `load_materials.iter().cloned()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone = note: `#[warn(clippy::map_clone)]` on by default

warning: dereferencing a tuple pattern where every element takes a reference --> src/support/car.rs:547:17 | 547 | &ActorNode::MeshfileRef(ref name) => { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference = note: `#[warn(clippy::needless_borrowed_reference)]` on by default help: try removing the `&` and `ref` parts | 547 - &ActorNode::MeshfileRef(ref name) => { 547 + ActorNode::MeshfileRef(name) => { |

warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` --> src/support/car.rs:546:13 | 546 | / match actor.data() { 547 | | &ActorNode::MeshfileRef(ref name) => { 548 | | if !car_meshes.contains_key(name) { 549 | | load_models.push(name.clone()) ... | 552 | | _ => (), 553 | | } | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match = note: `#[warn(clippy::single_match)]` on by default help: try | 546 ~ if let &ActorNode::MeshfileRef(ref name) = actor.data() { 547 + if !car_meshes.contains_key(name) { 548 + load_models.push(name.clone()) 549 + } 550 + } |

warning: this expression creates a reference which is immediately dereferenced by the compiler --> src/support/car.rs:537:13 | 537 | &Path::new("ACTORS"), | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `Path::new("ACTORS")` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: called `skip(..).next()` on an iterator --> src/support/car.rs:500:32 | 500 | .split(" version ") | ________________________________^ 501 | | .skip(1) 502 | | .next() | |___________________^ help: use `nth` instead: `.nth(1)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next = note: `#[warn(clippy::iter_skip_next)]` on by default

warning: single-character string constant used as pattern --> src/support/car.rs:430:34 | 430 | .map(|act| act.split(",")) | ^^^ help: try using a `char` instead: `','` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern = note: `#[warn(clippy::single_char_pattern)]` on by default

warning: this expression creates a reference which is immediately dereferenced by the compiler --> src/support/car.rs:348:13 | 348 | &Path::new("CARS"), | ^^^^^^^^^^^^^^^^^^ help: change this to: `Path::new("CARS")` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> src/support/car.rs:347:13 | 347 | &Path::new(fname.as_str()), | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `Path::new(fname.as_str())` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> src/support/car.rs:306:56 | 306 | let mat_file_name = path_subst(&mat_file_name, &Path::new("MATERIAL"), None); | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `Path::new("MATERIAL")` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

warning: this expression creates a reference which is immediately dereferenced by the compiler --> src/support/car.rs:280:13 | 280 | &Path::new("MODELS"), | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `Path::new("MODELS")` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default

warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do --> src/support/car.rs:266:18 | 266 | load_models: &Vec<String>, | ^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg help: change this to | 266 ~ load_models: &[String], 267 | car_meshes: &mut HashMap<String, Mesh>, 268 | ) -> Result<(), Error> { 269 ~ let mut load_models = load_models.to_owned(); |

warning: writing `&String` instead of `&str` involves a new object where a slice will do --> src/support/car.rs:51:23 | 51 | fn parse_vector(line: &String) -> Vector3<f32> { | ^^^^^^^ help: change this to: `&str` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: `#[warn(clippy::ptr_arg)]` on by default

warning: you should consider adding a `Default` implementation for `CameraState` --> src/support/camera.rs:30:5 | 30 | / pub fn new() -> CameraState { 31 | | CameraState { 32 | | // Keep ratio fixed at 4/3 33 | | aspect_ratio: 4.0 / 3.0, ... | 55 | | } 56 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default = note: `#[warn(clippy::new_without_default)]` on by default help: try adding this | 29 + impl Default for CameraState { 30 + fn default() -> Self { 31 + Self::new() 32 + } 33 + } |

warning: variable does not need to be mutable --> src/main.rs:170:9 | 170 | let mut events_loop = glium::glutin::event_loop::EventLoop::new(); | ----^^^^^^^^^^^ | | | help: remove this `mut` | = note: `#[warn(unused_mut)]` on by default

warning: redundant field names in struct initialization --> src/support/actor.rs:53:13 | 53 | root_id: root_id, | ^^^^^^^^^^^^^^^^ help: replace it with: `root_id` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names

warning: redundant field names in struct initialization --> src/support/actor.rs:52:13 | 52 | tree: tree, | ^^^^^^^^^^ help: replace it with: `tree` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names = note: `#[warn(clippy::redundant_field_names)]` on by default

warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool attributes --> src/support/mesh.rs:168:5 | 168 | #[cfg_attr(rustfmt, rustfmt_skip)] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr = note: `#[warn(clippy::deprecated_cfg_attr)]` on by default

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/toolchain@v1, actions/cache@v2, codecov/codecov-action@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions/cache@v2, codecov/codecov-action@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/