Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update bwa-0.7.17: enable linux-aarch64 build #46461

Closed
wants to merge 2 commits into from
Closed

update bwa-0.7.17: enable linux-aarch64 build #46461

wants to merge 2 commits into from

Conversation

guozhicong
Copy link
Contributor

Describe your pull request here


Please read the guidelines for Bioconda recipes before opening a pull request (PR).

General instructions

  • If this PR adds or updates a recipe, use "Add" or "Update" appropriately as the first word in its title.
  • New recipes not directly relevant to the biological sciences need to be submitted to the conda-forge channel instead of Bioconda.
  • PRs require reviews prior to being merged. Once your PR is passing tests and ready to be merged, please issue the @BiocondaBot please add label command.
  • Please post questions on Gitter or ping @bioconda/core in a comment.

Instructions for avoiding API, ABI, and CLI breakage issues

Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify run_exports (see here for the rationale and comprehensive explanation).
Add a run_exports section like this:

build:
  run_exports:
    - ...

with ... being one of:

Case run_exports statement
semantic versioning {{ pin_subpackage("myrecipe", max_pin="x") }}
semantic versioning (0.x.x) {{ pin_subpackage("myrecipe", max_pin="x.x") }}
known breakage in minor versions {{ pin_subpackage("myrecipe", max_pin="x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
known breakage in patch versions {{ pin_subpackage("myrecipe", max_pin="x.x.x") }} (in such a case, please add a note that shortly mentions your evidence for that)
calendar versioning {{ pin_subpackage("myrecipe", max_pin=None) }}

while replacing "myrecipe" with either name if a name|lower variable is defined in your recipe or with the lowercase name of the package in quotes.

Bot commands for PR management

Please use the following BiocondaBot commands:

Everyone has access to the following BiocondaBot commands, which can be given in a comment:

@BiocondaBot please update Merge the master branch into a PR.
@BiocondaBot please add label Add the please review & merge label.
@BiocondaBot please fetch artifacts Post links to CI-built packages/containers.
You can use this to test packages locally.

Note that the @BiocondaBot please merge command is now depreciated. Please just squash and merge instead.

Also, the bot watches for comments from non-members that include @bioconda/<team> and will automatically re-post them to notify the addressed <team>.

@jmarshall
Copy link
Member

jmarshall commented Mar 15, 2024

BWA 0.7.17 contains x86 SIMD code, so does not compile on ARM:

07:40:22 BIOCONDA INFO (OUT) ksw.c:29:10: fatal error: emmintrin.h: No such file or directory

An ARM port of this code (lh3/bwa#359) was merged 18 months ago but has not yet appeared in a bwa release.

In order to feasibly produce a linux-aarch64 package of BWA, @bioconda/core must lobby upstream for a new release.

@martin-g
Copy link
Contributor

Here is an issue asking for a new release - lh3/bwa#401

I have seen some recipes using Git SHA as a version. A proper upstream release would be better but maybe this is an option too ?!

@guozhicong guozhicong closed this Mar 15, 2024
@guozhicong guozhicong reopened this Mar 15, 2024
@BiocondaBot
Copy link
Collaborator

Reposting for @guozhicong to enable pings (courtesy of the BiocondaBot):

BWA 0.7.17 contains x86 SIMD code, so does not compile on ARM:

07:40:22 BIOCONDA INFO (OUT) ksw.c:29:10: fatal error: emmintrin.h: No such file or directory

An ARM port of this code (lh3/bwa#359) was merged 18 months ago but has not yet appeared in a bwa release.

In order to feasibly produce a linux-aarch64 package of BWA, @bioconda/core must lobby upstream for a new release.

BWA 0.7.17 包含 x86 SIMD 代码,因此无法在 ARM 上编译:

07:40:22 BIOCONDA INFO (OUT) ksw.c:29:10: fatal error: emmintrin.h: No such file or directory

此代码的 ARM 移植版 ( lh3/bwa#359 ) 已于 18 个月前合并,但尚未出现在 bwa 版本中。

为了切实可行地生成 BWA 的 linux-aarch64 包,@bioconda/core 必须游说上游发布新版本。

@guozhicong
Copy link
Contributor Author

guozhicong commented Mar 15, 2024

@jmarshall @martin-g Can I fix this problem by replacing the header file emmintrin.h with sse2neon.h as this README describes.

@martin-g
Copy link
Contributor

From lh3/bwa#359 :

| There are already BWA PRs lh3/bwa#283 and lh3/bwa#344, which port the SIMD code to other platforms using SIMDe and sse2neon respectively

You can read the PR descriptions for all the history.

@jmarshall
Copy link
Member

No. It would not be appropriate for bioconda to take on the maintenance burden of porting bwa to sse2neon. Moreover the work has already been done; and PR lh3/bwa#359 explains why that PR's approach is superior to a naive sse2neon port.

The appropriate approach for bioconda is to lobby for a new upstream release, as that is of benefit to the wider community. The other (inferior) approach open to bioconda IMHO is to apply that PR as a patch. Any other approach is not a feasible burden for bioconda IMHO.

@guozhicong
Copy link
Contributor Author

@jmarshall @martin-g Thanks!!! It's impossible for BWA to release a new version in the near future. I'll apply that PR lh3/bwa#359 as a patch to fix this problem.

@martin-g
Copy link
Contributor

It's impossible for BWA to release a new version in the near future

Do you know that from the maintainer ?
Or you meant to say "if it is impossible ..." ?

@jmarshall
Copy link
Member

Whether to take on the burden of patching this is also a question for @bioconda/core. IMHO we should not, as this is an excellent opportunity to encourage a long-overdue new release.

@guozhicong
Copy link
Contributor Author

@martin-g Sorry ... I mean to say "if it is impossible ..."

@rpetit3 rpetit3 added the aarch64 Related to adding linux-aarch64 support label Mar 20, 2024
@guozhicong guozhicong closed this by deleting the head repository Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aarch64 Related to adding linux-aarch64 support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants