-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update bwa-0.7.17: enable linux-aarch64 build #46461
Conversation
BWA 0.7.17 contains x86 SIMD code, so does not compile on ARM:
An ARM port of this code (lh3/bwa#359) was merged 18 months ago but has not yet appeared in a bwa release. In order to feasibly produce a linux-aarch64 package of BWA, @bioconda/core must lobby upstream for a new release. |
Here is an issue asking for a new release - lh3/bwa#401 I have seen some recipes using Git SHA as a version. A proper upstream release would be better but maybe this is an option too ?! |
Reposting for @guozhicong to enable pings (courtesy of the BiocondaBot):
|
@jmarshall @martin-g Can I fix this problem by replacing the header file emmintrin.h with sse2neon.h as this README describes. |
From lh3/bwa#359 : | There are already BWA PRs lh3/bwa#283 and lh3/bwa#344, which port the SIMD code to other platforms using SIMDe and sse2neon respectively You can read the PR descriptions for all the history. |
No. It would not be appropriate for bioconda to take on the maintenance burden of porting bwa to sse2neon. Moreover the work has already been done; and PR lh3/bwa#359 explains why that PR's approach is superior to a naive sse2neon port. The appropriate approach for bioconda is to lobby for a new upstream release, as that is of benefit to the wider community. The other (inferior) approach open to bioconda IMHO is to apply that PR as a patch. Any other approach is not a feasible burden for bioconda IMHO. |
@jmarshall @martin-g Thanks!!! It's impossible for BWA to release a new version in the near future. I'll apply that PR lh3/bwa#359 as a patch to fix this problem. |
Do you know that from the maintainer ? |
Whether to take on the burden of patching this is also a question for @bioconda/core. IMHO we should not, as this is an excellent opportunity to encourage a long-overdue new release. |
@martin-g Sorry ... I mean to say "if it is impossible ..." |
Describe your pull request here
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
General instructions
@BiocondaBot please add label
command.@bioconda/core
in a comment.Instructions for avoiding API, ABI, and CLI breakage issues
Conda is able to record and lock (a.k.a. pin) dependency versions used at build time of other recipes.
This way, one can avoid that expectations of a downstream recipe with regards to API, ABI, or CLI are violated by later changes in the recipe.
If not already present in the meta.yaml, make sure to specify
run_exports
(see here for the rationale and comprehensive explanation).Add a
run_exports
section like this:with
...
being one of:{{ pin_subpackage("myrecipe", max_pin="x") }}
{{ pin_subpackage("myrecipe", max_pin="x.x") }}
{{ pin_subpackage("myrecipe", max_pin="x.x") }}
(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin="x.x.x") }}
(in such a case, please add a note that shortly mentions your evidence for that){{ pin_subpackage("myrecipe", max_pin=None) }}
while replacing
"myrecipe"
with eithername
if aname|lower
variable is defined in your recipe or with the lowercase name of the package in quotes.Bot commands for PR management
Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update
@BiocondaBot please add label
please review & merge
label.@BiocondaBot please fetch artifacts
You can use this to test packages locally.
Note that the
@BiocondaBot please merge
command is now depreciated. Please just squash and merge instead.Also, the bot watches for comments from non-members that include
@bioconda/<team>
and will automatically re-post them to notify the addressed<team>
.