Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Japanese Locale #286

Merged
merged 3 commits into from
Aug 29, 2023
Merged

Disable Japanese Locale #286

merged 3 commits into from
Aug 29, 2023

Conversation

cassidysymons
Copy link
Collaborator

For the initial relaunch period, we're disabling Japanese as timing prevented us from completing a full review with the Tokyo Tech team.

session[LANG_KEY] = primary["language"]
# NB: Disabling Japanese for the initial relaunch period until the
# Tokyo Tech team can review finalized translations
if primary["language"] == "ja_JP":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there risk of exposure to other variations of the localization tag (e.g. just "ja")?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, primary["language"] is coming out of the ag.account table which will always be the standardized locale value.

cassidysymons and others added 2 commits August 28, 2023 14:26
Co-authored-by: Daniel McDonald <danielmcdonald@ucsd.edu>
Co-authored-by: Daniel McDonald <danielmcdonald@ucsd.edu>
@wasade wasade merged commit 7a3f906 into master-overhaul Aug 29, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants