Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Alpha Diversity Metric #319

Merged
merged 9 commits into from
Jun 17, 2024
Merged

Conversation

cassidysymons
Copy link
Collaborator

This pull request changes the alpha diversity metric used in the stool report from observed_features to shannon and updates supporting text accordingly.

Copy link
Member

@wasade wasade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be changes to the translation materials?

microsetta_interface/templates/new_results_page.jinja2 Outdated Show resolved Hide resolved
microsetta_interface/templates/new_results_page.jinja2 Outdated Show resolved Hide resolved
microsetta_interface/templates/new_results_page.jinja2 Outdated Show resolved Hide resolved
cassidysymons and others added 2 commits June 17, 2024 13:09
Co-authored-by: Daniel McDonald <danielmcdonald@ucsd.edu>
@cassidysymons
Copy link
Collaborator Author

Thanks for the quick review, @wasade

Should there be changes to the translation materials?

I hold on all translation updates until a single, pre-deployment step to minimize back-and-forth and the potential for translating text that might change again before a release is cut.

@cassidysymons cassidysymons merged commit 3a72f0d into master Jun 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants