added last_update column to ag_kit_barcodes #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cassidysymons
requested changes
Jan 30, 2024
| @@ -51,7 +52,7 @@ def from_db(cls, sample_id, date_collected, time_collected, | |||
| datetime_collected = datetime.combine(date_collected, | |||
| time_collected) | |||
| return cls(sample_id, datetime_collected, site, notes, barcode, | |||
| latest_scan_timestamp, source_id, | |||
| latest_scan_timestamp, last_update, source_id, | |||
| account_id, sample_projects, latest_scan_status) | |||
|
|
|||
| def to_api(self): | |||
wasade
reviewed
Jan 30, 2024
| ADD COLUMN last_update timestamp with time zone; | ||
|
|
||
| COMMENT ON COLUMN ag.ag_kit_barcodes.last_update | ||
| IS 'Sample metadata update timestamp'; |
There was a problem hiding this comment.
As a field name, last_update is ambiguous. Can the field reflect the type of update it corresponds too?
There was a problem hiding this comment.
Let's change this field name to latest_sample_information_update to clearly state that it's only tracking the info that belongs directly to a sample (e.g. collection date/time and type) and is ignoring other associations like metadata.
Also, we do not need to null the column when a sample is deleted, but it would be beneficial to add a comment to the sample deletion code noting this decision and suggesting it be revisited if we ever use the new column for anything other than its current purpose of UI enhancement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added last_update column to ag_kit_barcodes table. This will enable a more descriptive sample status on the 'My Reports' tab. See PR for microsetta-interface for FE changes.