Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sample summary report expansion #585

Merged
merged 13 commits into from
Oct 29, 2024

Conversation

ayobi
Copy link
Contributor

@ayobi ayobi commented Oct 3, 2024

At the moment, to get a sample summary report, 2 of the 3 ways we do this is by searching for a single barcode or searching through a csv file of barcodes. With this expansion, we are also going to be able to search via Kit ID, Email, Outbound Tracking Number, and Inbound Tracking Number and also see these fields in the output of the report.

@ayobi ayobi changed the title Sample summary report expansion sample summary report expansion Oct 3, 2024
Copy link
Collaborator

@cassidysymons cassidysymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please let me know if you have any questions about the feedback provided. I'm a bit surprised at some of the logic reflected in the code and it would be helpful to understand the choices.

microsetta_private_api/admin/admin_impl.py Outdated Show resolved Hide resolved
microsetta_private_api/admin/sample_summary.py Outdated Show resolved Hide resolved
microsetta_private_api/admin/sample_summary.py Outdated Show resolved Hide resolved
microsetta_private_api/repo/admin_repo.py Outdated Show resolved Hide resolved
microsetta_private_api/repo/admin_repo.py Outdated Show resolved Hide resolved
microsetta_private_api/repo/admin_repo.py Outdated Show resolved Hide resolved
microsetta_private_api/repo/admin_repo.py Outdated Show resolved Hide resolved
microsetta_private_api/repo/kit_repo.py Outdated Show resolved Hide resolved
@ayobi ayobi marked this pull request as ready for review October 21, 2024 23:40
microsetta_private_api/admin/sample_summary.py Outdated Show resolved Hide resolved
microsetta_private_api/admin/sample_summary.py Outdated Show resolved Hide resolved
microsetta_private_api/repo/admin_repo.py Show resolved Hide resolved
@cassidysymons cassidysymons merged commit ea6cd51 into biocore:master Oct 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants