-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sample summary report expansion #585
Merged
cassidysymons
merged 13 commits into
biocore:master
from
ayobi:sample_summary_report_expansion
Oct 29, 2024
Merged
sample summary report expansion #585
cassidysymons
merged 13 commits into
biocore:master
from
ayobi:sample_summary_report_expansion
Oct 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cassidysymons
requested changes
Oct 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please let me know if you have any questions about the feedback provided. I'm a bit surprised at some of the logic reflected in the code and it would be helpful to understand the choices.
cassidysymons
requested changes
Oct 22, 2024
cassidysymons
requested changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, to get a sample summary report, 2 of the 3 ways we do this is by searching for a single barcode or searching through a csv file of barcodes. With this expansion, we are also going to be able to search via Kit ID, Email, Outbound Tracking Number, and Inbound Tracking Number and also see these fields in the output of the report.