Update python version and matplotlib version #66
Conversation
|
Well I thought I was changing the python versions for the CI build (in the |
Data type. Version 3.10 is the same as 3.1 if it's treated as a floating point number. If you quote it, it becomes a string, and then "3.10" is handled correctly. |
.github/workflows/cibuild.yml
Outdated
| @@ -9,7 +9,7 @@ jobs: | |||
| strategy: | |||
| max-parallel: 4 | |||
| matrix: | |||
| python-version: [3.7, 3.8, 3.9] | |||
| python-version: ["3.10", "3.11", "3.12"] | |||
There was a problem hiding this comment.
I'm not sure Python 3.12 is ready for prime time. Pretty sure that failure has to do with versioneer.
There was a problem hiding this comment.
Looks like the bug has already been fixed in versioneer. So maybe instead of dropping 3.12 from the CI build matrix, I'll try updating it using these instructions.
lusSTR/__init__.py
Outdated
|
|
||
| from . import _version | ||
| __version__ = _version.get_versions()['version'] |
There was a problem hiding this comment.
Whoops, this got duplicated. Lemme fix that.
|
Yep, the 3.12 build just failed due to pkg_resources. |
|
Merge the other PR!! Quick!! |
|
lol yep Just a couple more comments |
Updating the Matplotlib version to >=3.8 (which requires update to Python 3.10), removes the pkg_resources Warning message.