Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update python version and matplotlib version #66

Merged
merged 7 commits into from
Dec 14, 2023
Merged

Update python version and matplotlib version #66

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
abcc08f
update python version and matplotlib version
rnmitchell Dec 13, 2023
f0e02fc
updated python versions in cibuild
rnmitchell Dec 13, 2023
b2a82b9
fixed python version
rnmitchell Dec 13, 2023
6dcbf90
Update bundled versioneer module
Dec 13, 2023
bedf7af
Cleanup on aisle __init__
Dec 13, 2023
4acea86
Merge
Dec 14, 2023
0972fb3
Fix CI config
Dec 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/cibuild.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
strategy:
max-parallel: 4
matrix:
python-version: [3.7, 3.8, 3.9]
python-version: ["3.10", "3.11", "3.12"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure Python 3.12 is ready for prime time. Pretty sure that failure has to do with versioneer.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But wait!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the bug has already been fixed in versioneer. So maybe instead of dropping 3.12 from the CI build matrix, I'll try updating it using these instructions.


steps:
- uses: actions/checkout@v1
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ conda install -c bioconda lusstr
```
Contributors/developers who want to create a dedicated environment on their machine can do so:
```
conda create --name lusSTR -y python=3.7 pandas
conda create --name lusSTR -y python=3.10 pandas
git clone https://www.github.com/bioforensics/lusSTR.git
cd lusSTR
make devenv
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
"openpyxl>=3.0.6",
"snakemake>=7.22.0",
"pyyaml>=6.0",
"matplotlib>=3.5.3",
"matplotlib>=3.8",
],
entry_points={"console_scripts": ["lusstr = lusSTR.cli:main"]},
scripts=glob.glob("lusSTR/scripts/*"),
Expand Down
Loading