custom implementation of is_supported_image classmethod #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toloudis
requested review from
hughes036,
evamaxfield,
SeanLeRoy,
yrkim98,
tyler-foster,
BrianWhitneyAI and
pgarrison
evamaxfield
approved these changes
Apr 29, 2024
BrianWhitneyAI
approved these changes
Apr 29, 2024
pgarrison
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Relevant Issue
This pull request resolves bioio-devs/bioio#41
Description of Changes
Ome-zarr reader needs to do a custom check for file support - in particular in the case where we are using http, a regular fsspec existence check will fail for directory paths.
The repro case described in bioio-devs/bioio#41 now works after these changes and the ones in bioio-devs/bioio#42