Remove special case for S3 paths #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanLeRoy
requested review from
toloudis,
hughes036,
evamaxfield,
yrkim98 and
BrianWhitneyAI
toloudis
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
LGTM, Thanks for updating this.
Just one thought: do we want to say the opposite thing, like "If you are reading from a non-public S3 bucket, you will have to have AWS credentials present, or pass them using the fs_kwargs argument - see s3fs docs for more info"
[EDIT] I was thinking for the main bioio repo. For this repo is all good IMO
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to bioio-devs/bioio#67 this other PR where
bioiowill now automatically use theanonattr forfs_kwargsif it doesn't correctly auth the first time around.