Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: p2p mtm #686

Closed
wants to merge 1 commit into from
Closed

feat: p2p mtm #686

wants to merge 1 commit into from

Conversation

arkadiuszos4chain
Copy link
Collaborator

@arkadiuszos4chain arkadiuszos4chain commented Dec 2, 2024 •
edited
Loading

Description of Changes

Linked Issues / Tickets

Reference any related issues or tickets, e.g. "Closes #123".

Testing Procedure

Describe the tests you've added or any testing steps you've taken.

  • I have added new unit tests
  • All tests pass locally
  • I have tested manually in my local environment

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have updated CHANGELOG.md with my changes

@arkadiuszos4chain arkadiuszos4chain self-assigned this Dec 2, 2024
@arkadiuszos4chain arkadiuszos4chain marked this pull request as ready for review December 3, 2024 14:45
@arkadiuszos4chain arkadiuszos4chain force-pushed the feat-p2p-mtm branch 3 times, most recently from 0c1d682 to 0712138 Compare December 5, 2024 14:54
kuba-4chain
kuba-4chain reviewed Dec 5, 2024
View reviewed changes
internal/metamorph/stats_collector_test.go Outdated Show resolved Hide resolved
internal/metamorph/zmq.go Outdated Show resolved Hide resolved
internal/p2p/batch_processor.go Outdated Show resolved Hide resolved
internal/p2p/network_messenger.go Outdated Show resolved Hide resolved
@pawellewandowski98 pawellewandowski98 mentioned this pull request Dec 6, 2024
Merged
7 tasks
@arkadiuszos4chain arkadiuszos4chain force-pushed the feat-p2p-mtm branch 4 times, most recently from daba2c0 to ba5b03a Compare December 9, 2024 08:13
boecklim
boecklim reviewed Dec 9, 2024
View reviewed changes
internal/metamorph/bcnet/metamorph_p2p/message_handler.go Outdated
Status: metamorph_api.Status_SEEN_ON_NETWORK,
Peer: peer.String(),
}:
default: // Ensure that writing to channel is non-blocking -- probably we should give up on this
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, this will not be needed anymore soon

@arkadiuszos4chain arkadiuszos4chain force-pushed the feat-p2p-mtm branch 2 times, most recently from f3c8383 to c7b947c Compare December 9, 2024 13:26
kuba-4chain
kuba-4chain reviewed Dec 9, 2024
View reviewed changes
internal/p2p/peer.go Outdated Show resolved Hide resolved
@boecklim boecklim mentioned this pull request Dec 9, 2024
Merged
7 tasks
@arkadiuszos4chain arkadiuszos4chain changed the base branch from main to feat-p2p-blocktx December 18, 2024 19:13
@arkadiuszos4chain arkadiuszos4chain force-pushed the feat-p2p-mtm branch 2 times, most recently from b800d75 to 9a0966e Compare December 18, 2024 19:27
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
80.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@boecklim boecklim mentioned this pull request Jan 13, 2025
Merged
7 tasks
@boecklim
Copy link
Collaborator

Closing as replaced by #743

@boecklim boecklim closed this Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuba-4chain kuba-4chain Awaiting requested review from kuba-4chain

@boecklim boecklim Awaiting requested review from boecklim

Assignees

@arkadiuszos4chain arkadiuszos4chain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arkadiuszos4chain @boecklim @kuba-4chain