Fix: markdown render api change due to deprecation #2266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@blacksmithgu I'm sorry for the ping but this just solves a ancient problem with obsidian-dataview with big impact and public interest. (also see my other pr's) |
|
just tried this on android.. IT WORKS!! gosh now I can finally go to bed.. 11:07 PM here.. |
This was referenced Mar 13, 2024
blacksmithgu
approved these changes
Mar 15, 2024
|
@blacksmithgu would you mind doing a release? this code change literally fixes embeds for everyone on this planet and even allows for recursion. |
GottZ
added a commit
to GottZ/obsidian-dataview
that referenced
this pull request
Mar 17, 2024
This was referenced Mar 17, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #177
closes #781
https://docs.obsidian.md/Reference/TypeScript+API/MarkdownRenderer/renderMarkdown
https://docs.obsidian.md/Reference/TypeScript+API/MarkdownRenderer/render