Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move curl and httpie to final layer in dockerfile #821

Merged
merged 2 commits into from
Nov 23, 2024

Conversation

dylanmcreynolds
Copy link
Contributor

@dylanmcreynolds dylanmcreynolds commented Nov 22, 2024

Checklist

  • Add a Changelog entry

#794 attempted to add curl and httpie to the docker image as a tool to be used in health checks. However, it was added to the builder layer, not the runner layer and hence not available at run time. This PR moves this installation.

Before this change:

docker exec -it ta991 bash
root@16a473d8c0e1:/deploy# curl
bash: curl: command not found
root@16a473d8c0e1:/deploy# 

After:

docker exec -it a901 bash
root@a90185b67888:/deploy# curl
curl: try 'curl --help' or 'curl --manual' for more information
root@a90185b67888:/deploy# 

@danielballan
Copy link
Member

I should have tested that before merging. Heads up @Kezzsim.

@danielballan danielballan merged commit 79bb4dd into bluesky:main Nov 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants