Skip to content

Move curl and httpie to final layer in dockerfile #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 23, 2024
Merged

Move curl and httpie to final layer in dockerfile #821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
65ec328
move curl and httpie to final layer in dockerfile
dylanmcreynolds Nov 22, 2024
3487f85
docker fix changelog
dylanmcreynolds Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ Write the date in place of the "Unreleased" in the case a new version is release

## Unreleased

- Fix curl and httpie installation in docker image.

### Added

- Add HTTP endpoint `PATCH /array/full/{path}` to enable updating and
Expand Down
5 changes: 2 additions & 3 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,6 @@ FROM python:3.12-slim as builder
# We need gcc to compile thriftpy2, a secondary dependency.
RUN apt-get -y update && apt-get install -y git gcc

# We want cURL and httpie so healthchecks can be performed within the container
RUN apt-get install -y curl httpie

WORKDIR /code

# Ensure logs and error messages do not get stuck in a buffer.
Expand Down Expand Up @@ -52,6 +49,8 @@ FROM python:3.12-slim as runner
ENV VIRTUAL_ENV=/opt/venv
ENV PATH="$VIRTUAL_ENV/bin:$PATH"
COPY --from=builder $VIRTUAL_ENV $VIRTUAL_ENV
# We want cURL and httpie so healthchecks can be performed within the container
RUN apt-get update && apt-get install -y curl httpie

WORKDIR /deploy
RUN mkdir /deploy/config
Expand Down
Loading