feat: set finalized and safe hash (parlia) #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j75689
force-pushed
the
feat/parlia/finalized_hash
branch
from
b7fab30
to
bd16a0b
Compare
unclezoro
reviewed
Jul 9, 2024
unclezoro
reviewed
Jul 9, 2024
unclezoro
reviewed
Jul 9, 2024
unclezoro
reviewed
Jul 9, 2024
crates/bsc/tasks/src/task.rs
Outdated
| error!(target: "consensus::parlia", ?fcu_response, "Forkchoice update returned invalid response"); | ||
| break | ||
| } | ||
| ForkchoiceStatus::Syncing => { |
There was a problem hiding this comment.
if it is ForkchoiceStatus::Syncing, why both to send the update in the loop again?
There was a problem hiding this comment.
Because blocktree will return the fcu status code, the function here is to repeatedly send fcu until the Valid is returned.
unclezoro
reviewed
Jul 9, 2024
unclezoro
reviewed
Jul 9, 2024
unclezoro
approved these changes
Jul 11, 2024
j75689
force-pushed
the
feat/parlia/finalized_hash
branch
from
56da573
to
bee8093
Compare
j75689
force-pushed
the
feat/parlia/finalized_hash
branch
from
4b29bbb
to
f2a0a5a
Compare
j75689
force-pushed
the
feat/parlia/finalized_hash
branch
from
f2a0a5a
to
e247252
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
feat: set finalized and safe hash (parlia)
Rationale
Notifying
BlockchainTreeof finalized and safe hash can finalize the blocks, and rpc can query it using thefinalizedandsafetags.Example
n/a
Changes
Notable changes:
Potential Impacts
no