Fixed tab color regressions from https://github.com/brave/brave-core/pull/27008 #27123
Conversation
| mixer[kColorBraveVerticalTabHoveredBackground] = { | ||
| ui::AlphaBlend(kColorBraveVerticalTabActiveBackground, | ||
| kColorBraveVerticalTabInactiveBackground, | ||
| /* 40% opacity */ 0.4 * SK_AlphaOPAQUE)}; |
There was a problem hiding this comment.
@aguscruiz Re-used previously used color for hover color but maybe we want to use nala token for this?
There was a problem hiding this comment.
If it doesn't break anything, then sure, I'm all for that.
| mixer[kColorBraveVerticalTabHoveredBackground] = { | ||
| ui::AlphaBlend(kColorBraveVerticalTabActiveBackground, | ||
| kColorBraveVerticalTabInactiveBackground, | ||
| /* 40% opacity */ 0.4 * SK_AlphaOPAQUE)}; |
There was a problem hiding this comment.
@aguscruiz ditto for tor theme.
There was a problem hiding this comment.
Ideally yes, we should use the Nala token that we use for the regular dark mode but with the color of these private/tor windows. Should look ok if they work like on the design
There was a problem hiding this comment.
Tested kColorPrimitivePrivateWindow15/kColorPrimitiveTorWindow15 for tab hover color instead of this color blending in vertical tab mode and it seems fine.
There was a problem hiding this comment.
Ok cool! Yeah looks good
fix brave/brave-browser#43057 This is regression from #27008 `nala::kColorDesktopbrowserTabbarActiveTabVertical` and `nala::kColorDesktopbrowserTabbarHoverTabVertical` didn't work for private/tor window. Fixed by setting different colors for above in private/tor theme.
simonhong
force-pushed
the
fix_private_window_vertical_tab_color
branch
from
4834fd8 to
689e490
Compare
kColorPrimitivePrivateWindow15/kColorPrimitiveTorWindow15 for tab hover color in vertical tab mode.
|
set as draft as this will have more fix for fixing regressions from https://github.com/brave/brave-core/pull/27008/files |
fix brave/brave-browser#43052 When custom theme is used, we use different tile bg color and border color as custom theme could have any colors so it's difficult to generate tile color from them.
simonhong
changed the title
|
Pushed all. PTAL the above screenshots in the description. |
simonhong
force-pushed
the
fix_private_window_vertical_tab_color
branch
from
0628c16 to
37e3465
Compare
| mixer[kColorBraveSplitViewTileDivider] = {kColorTabDividerFrameActive}; | ||
| mixer[kColorBraveVerticalTabActiveBackground] = { | ||
| kColorTabBackgroundInactiveFrameActive}; | ||
| mixer[kColorBraveVerticalTabHoveredBackground] = { |
fix brave/brave-browser#43057
fix brave/brave-browser#43052
This is regression from #27008
Resolves
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: