Use correct [[targets.distros]] schema in RFC 0128
#312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates RFC 0128 to use the correct `[[targets.distros]]` schema as defined already in the spec: https://github.com/buildpacks/spec/blob/main/buildpack.md#buildpacktoml-toml I've not added an `## Amended` section, since: 1. The RFC has only just merged (this is effectively a review comment that missed the merge by a day) 2. The parts of the RFC being fixed are existing concepts already in the spec, rather than design decisions relating to the purpose of the RFC itself. Fixes: buildpacks#295 (comment) Signed-off-by: Ed Morley <501702+edmorley@users.noreply.github.com>
|
Maintainers, As you review this RFC please queue up issues to be created using the following commands: Issues(none) |
edmorley
force-pushed
the
rfc-0128-fix-schema
branch
from
bd1448b
to
55cfde3
Compare
edmorley
changed the title
[[targets.distros]] schema[[targets.distros]] schema in RFC 0128
|
@jjbustamante Could I have review? :-) |
jjbustamante
approved these changes
Apr 19, 2024
|
Just to be consistent with the process, I think we should add the Amend section at the bottom |
I explained why I didn't add this section in the PR description. I still think we shouldn't add one. |
|
Ultimately this is a typo fix to something unrelated to the RFC, not a change in the actual intent of the RFC. |
natalieparellano
approved these changes
Apr 22, 2024
|
Please can someone merge this? |
|
Thank you :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates RFC 0128 to use the correct
[[targets.distros]]schema as defined already in the spec:https://github.com/buildpacks/spec/blob/main/buildpack.md#buildpacktoml-toml
I've not added an
## Amendedsection, since:Fixes #295 (comment).