Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct [[targets.distros]] schema in RFC 0128 #312

Merged
merged 1 commit into from
May 14, 2024
Merged

Use correct [[targets.distros]] schema in RFC 0128 #312

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions text/0128-multiarch-builders-and-package.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,9 @@ arch = "arm64"
os = "windows"
arch = "amd64"

[[targets.distributions]]
[[targets.distros]]
name = "windows"
versions = ["10.0.20348.1970"]
version = "10.0.20348.1970"

# Stacks (deprecated) the buildpack will work with
[[stacks]]
Expand Down Expand Up @@ -286,9 +286,9 @@ variant = "<architecture variant>"
# optional
path = "<path to look for the binaries if the folder structure convention is not followed>"

[[targets.distributions]]
[[targets.distros]]
name = "<distribution ID>"
versions = ["<distribution version>"]
version = "<distribution version>"
```
- When `more than 1 target is defined`
- When `--publish` is specified
Expand Down Expand Up @@ -681,9 +681,9 @@ arch = "arm64"
os = "windows"
arch = "amd64"

[[targets.distributions]]
[[targets.distros]]
name = "windows"
versions = ["10.0.20348.1970"]
version = "10.0.20348.1970"

# Stacks (deprecated) the buildpack will work with
[[stacks]]
Expand Down Expand Up @@ -763,9 +763,9 @@ os = "<operating system>"
arch = "<system architecture>"
variant = "<architecture variant>"

[[targets.distributions]]
[[targets.distros]]
name = "<distribution ID>"
versions = ["<distribution version>"]
version = "<distribution version>"

[[dependencies]]
uri = "<A URL or path to an archive, a packaged buildpack (saved as a .cnb file), or a directory. If path is relative, it must be relative to the package.toml>"
Expand Down Expand Up @@ -843,9 +843,9 @@ image = "<build image reference>"
os = "<operating system>"
arch = "<system architecture>"
variant = "<architecture variant>"
[[targets.distributions]]
[[targets.distros]]
name = "<distribution ID>"
versions = ["<distribution version>"]
version = "<distribution version>"
```
- Add a new `--target` optional flag with format `[os][/arch][/variant]:[name@version]` to create a builder for a
particular target, this will help end-users to specify the platform for which they want to create single OCI artifact.
Expand Down
Loading