Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate to spring db naming scheme #3

Merged
merged 4 commits into from
Feb 14, 2024

Conversation

nr23730
Copy link
Contributor

@nr23730 nr23730 commented Jan 11, 2024

As 6.0.0 migrated to spring db I propose to also change this in the core library. Then the db settings in the application.properties only need to be defined once.

Goes together with: cBioPortal/cbioportal#10537

@nr23730 nr23730 marked this pull request as ready for review January 11, 2024 14:25
Copy link
Member

@inodb inodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @nr23730 ! Great catch!

@nr23730 nr23730 marked this pull request as draft January 12, 2024 17:40
@nr23730
Copy link
Contributor Author

nr23730 commented Jan 12, 2024

You're welcome! However, this need's some more love, as the java side won't connect to the db right now.

@nr23730 nr23730 marked this pull request as ready for review January 12, 2024 19:54
@JREastonMarks
Copy link
Contributor

Hi,
I wanted to let you know we haven't forgotten about this PR. I plan on merging it in after the 6.0.0 release which will hopefully happen soon.
~Jeremy

@JREastonMarks JREastonMarks self-requested a review February 14, 2024 14:06
Copy link
Contributor

@JREastonMarks JREastonMarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JREastonMarks JREastonMarks merged commit 3e1834d into cBioPortal:main Feb 14, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants