update the docker entrypoint for spring #10537
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nr23730
force-pushed
the
dockerSpringEntrypoint
branch
from
c6000a7 to
23f3d65
Compare
|
haynescd
reviewed
Jan 25, 2024
| ``` | ||
| db.tomcat_resource_name=jdbc/cbioportal | ||
| ``` | ||
| :warning: The fields `db.host` and `db.portal_db_name` and `db.use_ssl` and `db.connection_string` are deprecated. It is required to configure the database connection using |
There was a problem hiding this comment.
Good Fix.
Before we completely remove the legacy properties we need to remove them from the cbioportal-core repo
|
@haynescd will look whether these changes are still necessary (lot of it has been updated in master now) |
|
@nr23730 Can you rebase this branch with master. I think we accidentally got some of these changes in already |
|
@haynescd All relevant parts are already in master. So closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As 6.0.0 migrated to spring db I propose to also change this in the docker-entrypoint script. Then the db settings in the application.properties only need to be defined once.
Goes together with: cBioPortal/cbioportal-core#3