Skip to content

Conversation

@jbreue16
Copy link
Contributor

@jbreue16 jbreue16 commented Oct 23, 2025

This PR introduces hybrid models to CADET-Core, allowing the binding model to be replaced or approximated by a pre-trained neural network.

Todo

  • rebase code
    • resolve conflicts
    • add changes to generalized unit operations
    • squash commits, are there meaningful separate commits?
  • fix mkl inclusion (src/mkl_files)
  • add documentation
  • add more cadet-core tests?
  • add simple python code example to cadet-verification, where a NN is trained and plugged in

jazib-hassan-juelich and others added 30 commits May 5, 2021 10:29
…nd then perform the fitting process within CADET
…nd then perform the fitting process within CADET
@github-actions
Copy link

Thank you for your submission, we really appreciate it!

Like many open-source projects we ask that you sign our Contributor License Agreement before we can accept your contribution.
To sign, please post two separate comments based on the following templates 👇

  1. Comment:

- [ ] The CADET maintainers know my real name.

At least one of the following two applies:

- [ ] The CADET maintainers know my current employer.

- [ ] I am *not* making this contribution on behalf of my current employer.

  1. Comment:
    I have read the CLA Document and I hereby sign the CLA.
    You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@schmoelder
Copy link
Contributor

schmoelder commented Oct 24, 2025

Unfortunately, rebasing was not possible without additional work. Amongst other issues, the PR includes changes to the unit operation models and it's not quite clear yet as to why. I see the following options:

  • Investigate what other changes have been made in this PR. Maybe we're lucky and we figure it out quickly, but it could also be tedious
  • Start from scratch, using this PR merely as inspiration

Any preference @lieres?

@lieres
Copy link
Member

lieres commented Oct 24, 2025

@jazib-hassan-juelich, please have a look and comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

5 participants