Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
d049fd4
Added the option to accept empty adsoprtion fields in general rate mo…
jazib-hassan-juelich May 5, 2021
8f76eaa
Corrected a typo
jazib-hassan-juelich May 6, 2021
1257226
Added to branch
jazib-hassan-juelich May 6, 2021
c5fa458
Some progress on
jazib-hassan-juelich May 6, 2021
108c73d
Changed the implementation of GRM for no adsorption case in fewer lin…
jazib-hassan-juelich May 9, 2021
78d588a
Modified the GRM unit operation with correct naming convention
jazib-hassan-juelich May 10, 2021
93268e7
Adding NO_ADSOPRTION as default option in 2D GRM, LRMwP and LRmwoP
jazib-hassan-juelich May 11, 2021
1a12ca6
Remove the white space in GRM.cpp and added the NONE adsoprtion in el…
jazib-hassan-juelich May 11, 2021
4167147
White space deleted from GRM.cpp
jazib-hassan-juelich May 11, 2021
d4834ad
Added machine learning implementation to CADET
jazib-hassan-juelich May 11, 2021
1c0cc7c
Added the spline model and made few changes in NN implemenation appro…
jazib-hassan-juelich May 25, 2021
ce7e47f
Modified SPLINE isotherm so that it accepts c and q values as input a…
jazib-hassan-juelich Jun 18, 2021
7d3f480
Changed the alphabet case of the spline input paramters
jazib-hassan-juelich Jun 22, 2021
466ada5
Made a change in workspace method
jazib-hassan-juelich Jun 22, 2021
dcf2b44
Adding test script in test/BindingModels.cpp
jazib-hassan-juelich Jun 23, 2021
8ae4a9a
Enable AD in mlmodel()
jazib-hassan-juelich Jun 24, 2021
ee0055b
Merging all the changes in master with local
jazib-hassan-juelich Jun 24, 2021
2b588b6
Added Fruendlich Binding Model
jazib-hassan-juelich Jun 26, 2021
4c6c30f
Added to branch
jazib-hassan-juelich May 6, 2021
a204d3d
Some progress on
jazib-hassan-juelich May 6, 2021
017a719
Changed the implementation of GRM for no adsorption case in fewer lin…
jazib-hassan-juelich May 9, 2021
aa5bfd3
Modified the GRM unit operation with correct naming convention
jazib-hassan-juelich May 10, 2021
3a4cbf3
Adding NO_ADSOPRTION as default option in 2D GRM, LRMwP and LRmwoP
jazib-hassan-juelich May 11, 2021
2789832
Remove the white space in GRM.cpp and added the NONE adsoprtion in el…
jazib-hassan-juelich May 11, 2021
dae0367
White space deleted from GRM.cpp
jazib-hassan-juelich May 11, 2021
676752e
Added machine learning implementation to CADET
jazib-hassan-juelich May 11, 2021
0d641e8
Added the spline model and made few changes in NN implemenation appro…
jazib-hassan-juelich May 25, 2021
c40d2d5
Modified SPLINE isotherm so that it accepts c and q values as input a…
jazib-hassan-juelich Jun 18, 2021
3519843
Changed the alphabet case of the spline input paramters
jazib-hassan-juelich Jun 22, 2021
5aad30f
Made a change in workspace method
jazib-hassan-juelich Jun 22, 2021
1472233
Adding test script in test/BindingModels.cpp
jazib-hassan-juelich Jun 23, 2021
cde6a4d
Enable AD in mlmodel()
jazib-hassan-juelich Jun 24, 2021
79e34f6
Added Fruendlich Binding Model
jazib-hassan-juelich Jun 26, 2021
7ea076f
added approximation near origin in FLDF model
jazib-hassan-juelich Jul 2, 2021
c592297
Rebasing with master
jazib-hassan-juelich Jul 2, 2021
1d956a4
Clean the FLDF file that have issues in it due after rebasing
jazib-hassan-juelich Jul 3, 2021
89700c9
Merge branch 'modsim:master' into CADET_ML
jazib-hassan-juelich Jul 3, 2021
0eba9bf
Almost finalized form of Freundlich isotherm
jazib-hassan-juelich Jul 7, 2021
609143e
Merge branch 'CADET_ML' of https://github.com/jazib-hassan-juelich/CA…
jazib-hassan-juelich Jul 7, 2021
9c5b19b
Registring efunction binding model
jazib-hassan-juelich Aug 2, 2021
5cbff1c
Implementation of efunction binding model
jazib-hassan-juelich Aug 2, 2021
f24ad3d
Added a test binding model file for tutorial purpose
jazib-hassan-juelich Aug 3, 2021
6fac2cd
adding test runner and cmkaelists for new binding models
jazib-hassan-juelich Aug 19, 2021
64dc68c
Adding GPR binding model and class based implementation of ANN in CAD…
jazib-hassan-juelich Nov 4, 2021
76bb942
Cmakesetting file for Jazib local system
jazib-hassan-juelich Nov 4, 2021
1b11cd1
Adding the updated binding models
jazib-hassan-juelich Nov 23, 2021
c0cb0e7
Adding header files for mkl libs
jazib-hassan-juelich Nov 23, 2021
890d660
Merge branch 'modsim:master' into CADET_ML
jazib-hassan-juelich Nov 23, 2021
3758b05
Added comments in TestBinding.cpp
jazib-hassan-juelich Jan 3, 2022
84af96a
Adding the comments in TestBinding.cpp
jazib-hassan-juelich Jan 3, 2022
bee07eb
Adding the ANN binding model source files
jazib-hassan-juelich Feb 17, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ set(CMAKE_C_VISIBILITY_PRESET hidden)
set(CMAKE_CXX_VISIBILITY_PRESET hidden)
set(CMAKE_VISIBILITY_INLINES_HIDDEN ON)


# Enable folders for IDEs
set_property(GLOBAL PROPERTY USE_FOLDERS ON)

Expand Down
43 changes: 25 additions & 18 deletions CMakeSettings.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,22 +2,24 @@
// See https://go.microsoft.com//fwlink//?linkid=834763 for more information about this file.
"environments": [
{
"TBB_DIR": "C:/Program Files (x86)/IntelSWTools/compilers_and_libraries/windows/tbb",
"BLAS_DIR": "C:/Program Files (x86)/IntelSWTools/compilers_and_libraries/windows/mkl/lib/intel64_win",
"SUNDIALS_DIR": "${projectDir}/../../libs/sundials",
"HDF5_DIR": "${projectDir}/../../libs/hdf5",
"ZLIB": "${projectDir}/../../libs/hdf5/lib/zlib.lib",
"SZLIB": "${projectDir}/../../libs/hdf5/lib/szip.lib",
"TBB_DIR": "C:/Users/hassan/Desktop/Libs/tbb",
"BLAS_DIR": "C:/Program Files (x86)/IntelSWTools/compilers_and_libraries_2020/windows/mkl/lib/intel64_win",
"SUNDIALS_DIR": "C:/Users/hassan/Desktop/CADET_All/CADET_Jazib/Libs/sundials",
"HDF5_DIR": "C:/Users/hassan/Desktop/CADET_All/CADET_Jazib/Libs/hdf5_src/build/_CPack_Packages/win64/ZIP/HDF5-1.12.0-win64",
"ZLIB": "C:/Users/hassan/Desktop/CADET_All/CADET_Jazib/Libs/hdf5_src/build/_CPack_Packages/win64/ZIP/HDF5-1.12.0-win64/lib/zlib.lib",
"SZLIB": "C:/Users/hassan/Desktop/CADET_All/CADET_Jazib/Libs/hdf5_src/build/_CPack_Packages/win64/ZIP/HDF5-1.12.0-win64/lib/szip.lib",
"INSTALL_DIR": "${projectDir}/../cadet/${name}",
"BLAS_DEBUG": "Intel10_64lp_seq",
"BLAS_RELEASE": "Intel10_64lp_seq",
"BUILDROOT": "${env.USERPROFILE}\\CMakeBuild\\${workspaceHash}\\build\\${name}"
}
],


"configurations": [
{
"name": "MS_MKL_DEBUG",
"generator": "Visual Studio 15 2017 Win64",
"generator": "Visual Studio 16 2019 Win64",
"configurationType": "Debug",
"buildRoot": "${env.BUILDROOT}",
"cmakeCommandArgs": "",
Expand Down Expand Up @@ -64,7 +66,7 @@
"value": "${env.BLAS_DEBUG}"
},
{
"name": "CMAKE_INSTALL_PREFIX",
"name": "remoteInstallRoot",
"value": "${env.INSTALL_DIR}"
},
{
Expand All @@ -76,7 +78,7 @@
},
{
"name": "MS_MKL_RELEASE",
"generator": "Visual Studio 15 2017 Win64",
"generator": "Visual Studio 16 2019 Win64",
"configurationType": "Release",
"buildRoot": "${env.BUILDROOT}",
"cmakeCommandArgs": "",
Expand Down Expand Up @@ -127,7 +129,7 @@
"value": "${env.BLAS_RELEASE}"
},
{
"name": "CMAKE_INSTALL_PREFIX",
"name": "remoteInstallRoot",
"value": "${env.INSTALL_DIR}"
},
{
Expand All @@ -138,7 +140,7 @@
},
{
"name": "MS_MKL_RELDEBINFO",
"generator": "Visual Studio 15 2017 Win64",
"generator": "Visual Studio 16 2019",
"configurationType": "RelWithDebInfo",
"buildRoot": "${env.BUILDROOT}",
"cmakeCommandArgs": "",
Expand Down Expand Up @@ -189,7 +191,7 @@
"value": "${env.BLAS_RELEASE}"
},
{
"name": "CMAKE_INSTALL_PREFIX",
"name": "remoteInstallRoot",
"value": "${env.INSTALL_DIR}"
},
{
Expand All @@ -200,7 +202,7 @@
},
{
"name": "MS_SMKL_DEBUG",
"generator": "Visual Studio 15 2017 Win64",
"generator": "Visual Studio 16 2019",
"configurationType": "Debug",
"buildRoot": "${env.BUILDROOT}",
"cmakeCommandArgs": "",
Expand Down Expand Up @@ -247,7 +249,7 @@
"value": "${env.BLAS_DEBUG}"
},
{
"name": "CMAKE_INSTALL_PREFIX",
"name": "remoteInstallRoot",
"value": "${env.INSTALL_DIR}"
},
{
Expand All @@ -257,13 +259,18 @@
{
"name": "BLA_STATIC",
"value": "1"
},
{
"name": "BUILD_CADET_MEX",
"value": "False",
"type": "BOOL"
}
]

},
{
"name": "MS_SMKL_RELEASE",
"generator": "Visual Studio 15 2017 Win64",
"generator": "Visual Studio 16 2019",
"configurationType": "Release",
"buildRoot": "${env.BUILDROOT}",
"cmakeCommandArgs": "",
Expand Down Expand Up @@ -314,7 +321,7 @@
"value": "${env.BLAS_RELEASE}"
},
{
"name": "CMAKE_INSTALL_PREFIX",
"name": "remoteInstallRoot",
"value": "${env.INSTALL_DIR}"
},
{
Expand All @@ -329,7 +336,7 @@
},
{
"name": "MS_SMKL_RELDEBINFO",
"generator": "Visual Studio 15 2017 Win64",
"generator": "Visual Studio 16 2019",
"configurationType": "RelWithDebInfo",
"buildRoot": "${env.BUILDROOT}",
"cmakeCommandArgs": "",
Expand Down Expand Up @@ -380,7 +387,7 @@
"value": "${env.BLAS_RELEASE}"
},
{
"name": "CMAKE_INSTALL_PREFIX",
"name": "remoteInstallRoot",
"value": "${env.INSTALL_DIR}"
},
{
Expand Down
10 changes: 10 additions & 0 deletions src/libcadet/BindingModelFactory.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,11 @@ namespace cadet
void registerMultiComponentSpreadingModel(std::unordered_map<std::string, std::function<model::IBindingModel*()>>& bindings);
void registerGeneralizedIonExchangeModel(std::unordered_map<std::string, std::function<model::IBindingModel*()>>& bindings);
void registerColloidalModel(std::unordered_map<std::string, std::function<model::IBindingModel*()>>& bindings);
void registerMachineLearningModel(std::unordered_map<std::string, std::function<model::IBindingModel* ()>>& bindings);
void registerSplineModel(std::unordered_map<std::string, std::function<model::IBindingModel* ()>>& bindings);
void registerFreundlichLDFModel(std::unordered_map<std::string, std::function<model::IBindingModel* ()>>& bindings);
void registerEFunctionModel(std::unordered_map<std::string, std::function<model::IBindingModel* ()>>& bindings);
void registerGPRModel(std::unordered_map<std::string, std::function<model::IBindingModel* ()>>& bindings);
}
}

Expand All @@ -61,6 +66,11 @@ namespace cadet
model::binding::registerMultiComponentSpreadingModel(_bindingModels);
model::binding::registerGeneralizedIonExchangeModel(_bindingModels);
model::binding::registerColloidalModel(_bindingModels);
model::binding::registerMachineLearningModel(_bindingModels);
model::binding::registerSplineModel(_bindingModels);
model::binding::registerFreundlichLDFModel(_bindingModels);
model::binding::registerEFunctionModel(_bindingModels);
model::binding::registerGPRModel(_bindingModels);
registerModel<model::SimplifiedMultiStateStericMassActionBinding>();
}

Expand Down
13 changes: 9 additions & 4 deletions src/libcadet/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,11 @@ set(LIBCADET_BINDINGMODEL_SOURCES
${CMAKE_SOURCE_DIR}/src/libcadet/model/binding/MultiComponentSpreadingBinding.cpp
${CMAKE_SOURCE_DIR}/src/libcadet/model/binding/GeneralizedIonExchangeBinding.cpp
${CMAKE_SOURCE_DIR}/src/libcadet/model/binding/ColloidalBinding.cpp
${CMAKE_SOURCE_DIR}/src/libcadet/model/binding/MachineLearningBinding.cpp
${CMAKE_SOURCE_DIR}/src/libcadet/model/binding/SplineBinding.cpp
${CMAKE_SOURCE_DIR}/src/libcadet/model/binding/FreundlichLDFBinding.cpp
${CMAKE_SOURCE_DIR}/src/libcadet/model/binding/EFunctionBinding.cpp
${CMAKE_SOURCE_DIR}/src/libcadet/model/binding/GuassianProcessRegressionBinding.cpp
)

# LIBCADET_REACTIONMODEL_SOURCES holds all source files of reaction models
Expand Down Expand Up @@ -218,7 +223,7 @@ if (LAPACK_FOUND)
set(LIB_LAPACK_DEFINE "CADET_LAPACK_TRAILING_UNDERSCORE")

# Add the build target for the static nonlinalg library
add_library(libcadet_nonlinalg_static STATIC ${LIBCADET_NONLINALG_SOURCES} ${LIBCADET_NONLINALG_SPARSE_SOURCES})
add_library(libcadet_nonlinalg_static STATIC ${LIBCADET_NONLINALG_SOURCES} ${LIBCADET_NONLINALG_SPARSE_SOURCES} "model/binding/MachineLearningBinding.cpp" "model/binding/SplineBinding.cpp" "model/binding/EFunctionBinding.cpp" "model/binding/Class_ANN.h" "model/binding/GuassianProcessRegressionBinding.cpp")
set_target_properties(libcadet_nonlinalg_static PROPERTIES OUTPUT_NAME cadet_nonlinalg_static)
target_compile_definitions(libcadet_nonlinalg_static PRIVATE libcadet_nonlinalg_static_EXPORTS ${LIB_LAPACK_DEFINE})
target_link_libraries(libcadet_nonlinalg_static PUBLIC CADET::CompileOptions PRIVATE SUNDIALS::sundials_idas ${SUNDIALS_NVEC_TARGET} ${LAPACK_LIBRARIES})
Expand All @@ -234,7 +239,7 @@ if (LAPACK_FOUND)


# Add the build target for CADET object library
add_library(libcadet_object OBJECT ${LIBCADET_SOURCES})
add_library(libcadet_object OBJECT ${LIBCADET_SOURCES} "model/binding/MachineLearningBinding.cpp" "model/binding/SplineBinding.cpp" "model/binding/EFunctionBinding.cpp" "model/binding/Class_ANN.h" "model/binding/GuassianProcessRegressionBinding.cpp")
target_compile_definitions(libcadet_object PRIVATE libcadet_EXPORTS ${LIB_LAPACK_DEFINE})
target_link_libraries(libcadet_object PUBLIC CADET::CompileOptions CADET::LibOptions PRIVATE CADET::AD libcadet_nonlinalg_static SUNDIALS::sundials_idas ${SUNDIALS_NVEC_TARGET} ${TBB_TARGET})

Expand Down Expand Up @@ -280,7 +285,7 @@ if (ENABLE_CADET_MEX)
endif()

# Add the build target for the mex nonlinalg library
add_library(libcadet_nonlinalg_mex STATIC ${LIBCADET_NONLINALG_SOURCES} ${LIBCADET_NONLINALG_MEX_SOURCES})
add_library(libcadet_nonlinalg_mex STATIC ${LIBCADET_NONLINALG_SOURCES} ${LIBCADET_NONLINALG_MEX_SOURCES} "model/binding/MachineLearningBinding.cpp" "model/binding/SplineBinding.cpp" "model/binding/EFunctionBinding.cpp" "model/binding/Class_ANN.h" "model/binding/GuassianProcessRegressionBinding.cpp")
set_target_properties(libcadet_nonlinalg_mex PROPERTIES
OUTPUT_NAME cadet_nonlinalg_mex
LINK_SEARCH_START_STATIC ON
Expand Down Expand Up @@ -309,7 +314,7 @@ if (ENABLE_CADET_MEX)
endif()

# Add the build target for the mex CADET library
add_library(libcadet_mex STATIC ${LIBCADET_SOURCES})
add_library(libcadet_mex STATIC ${LIBCADET_SOURCES} "model/binding/MachineLearningBinding.cpp" "model/binding/SplineBinding.cpp" "model/binding/EFunctionBinding.cpp" "model/binding/Class_ANN.h" "model/binding/GuassianProcessRegressionBinding.cpp")
set_target_properties(libcadet_mex PROPERTIES
OUTPUT_NAME cadet_mex
LINK_SEARCH_START_STATIC ON
Expand Down
Loading
Loading