Fixing stringifyArea and adding test. #1

caduandrade · Sep 26, 2023 · 6df0f7d · 6df0f7d
1 parent 602378f
commit 6df0f7d
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 3 deletions.
diff --git a/lib/src/layout/layout_parser.dart b/lib/src/layout/layout_parser.dart
@@ -101,11 +101,16 @@ class LayoutParser {
   String stringifyArea({required DockingArea area}) {
     List<String> data = [];
     // WEIGHT
-    data.add('${area.minimalWeight?.toString()}');
+    final String weight = area.weight != null ? area.weight.toString() : '';
+    data.add(weight);
     // MINIMAL_SIZE
-    data.add('${area.minimalWeight?.toString()}');
+    final String minimalWeight =
+        area.minimalWeight != null ? area.minimalWeight.toString() : '';
+    data.add(minimalWeight);
     // MINIMAL_SIZE
-    data.add('${area.minimalSize?.toString()}');
+    final String minimalSize =
+        area.minimalSize != null ? area.minimalSize!.toStringAsFixed(0) : '';
+    data.add(minimalSize);
 
     return data.join(';');
   }

diff --git a/test/layout_stringify_test.dart b/test/layout_stringify_test.dart
@@ -1,4 +1,5 @@
 import 'package:docking/docking.dart';
+import 'package:flutter/widgets.dart';
 import 'package:flutter_test/flutter_test.dart';
 
 import 'exceptions.dart';
@@ -31,5 +32,28 @@ void main() {
       expect(parser.stringifyParent(parent: row), '4,5');
       expect(parser.stringifyParent(parent: tabs), '7,8');
     });
+    test('stringifyArea', () {
+      DockingItem itemA = DockingItem(widget: Container());
+      DockingItem itemB = DockingItem(widget: Container(), weight: .2);
+      DockingItem itemC = DockingItem(widget: Container(), minimalSize: 100);
+      DockingItem itemD = DockingItem(widget: Container(), minimalWeight: .2);
+      DockingItem itemE =
+          DockingItem(widget: Container(), weight: .3, minimalWeight: .2);
+      DockingRow row = DockingRow([itemB, itemC], weight: .4);
+      DockingTabs tabs = DockingTabs([itemD, itemE], minimalSize: 200);
+      DockingColumn column =
+          DockingColumn([itemA, row, tabs], minimalWeight: .5);
+
+      DockingLayout(root: column);
+
+      expect(parser.stringifyArea(area: column), ';0.5;');
+      expect(parser.stringifyArea(area: row), '0.4;;');
+      expect(parser.stringifyArea(area: tabs), ';;200');
+      expect(parser.stringifyArea(area: itemA), ';;');
+      expect(parser.stringifyArea(area: itemB), '0.2;;');
+      expect(parser.stringifyArea(area: itemC), ';;100');
+      expect(parser.stringifyArea(area: itemD), ';0.2;');
+      expect(parser.stringifyArea(area: itemE), '0.3;0.2;');
+    });
   });
 }