-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MicroCloud look and feel #505
Conversation
49e24dc
to
75238eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, looks very good and makes fun playing around with the new UX additions. Also the table navigation is very clean.
I have commented on a few places about minor things but will put some general comments to the new colors/font weight here.
I like the fact that the users input (as well as the default values throughout the questionnaire) is now highlighted using bold text. But also marking it yellow feels a bit too much. I am having a hard time reason about the yellow for such types of inputs if other (good) things are marked green and errors are in red. But that's personal preference I guess.
Just using bold text would be enough I think.
Then colors are really dedicated for errors, actual warnings (yellow) and security related notes (fingerprints, passphrases) in green.
Something else I just came across, can we maybe introduce something like a "note" to display messages like To keep it simple maybe just a colored box like in the example here (using a more modest color though) |
Interesting idea to have a |
The reason for the colouring is two-fold:
Yellow basically just means "look at this", but does not signify any problem that must be addressed for the cluster to form. |
6097eea
to
217fed2
Compare
I've added a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the note box, looks very good and helpful in my opinion!
Just did some more deploys with the changes from this PR and thought the storage disk error for single node deployments should maybe also be put into such a box for consistency? Another candidate might be the subnet collision warning. This could already give a hint for the changes in #522.
Couple ways to go about this:
I'll give each version a try and see what looks best. |
@masnax ready for final review? I saw you pushed some more changes. And your commits look to be partially unverified. |
Ah shoot, I switched ssh keys for launchpad and broke github. I'll fix that :) The changes were just a bugfix around |
Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
Signed-off-by: Max Asnaashari <max.asnaashari@canonical.com>
@roosterfish Commits are fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Uses https://github.com/charmbracelet/lipgloss to implement tables and questions in MicroCloud.
There is much more colour in the CLI now. This can be disabled with the
NO_COLOR
environment variable or the--no-color
flag.make build-test
has been added to the Makefile, which builds MicroCloud with different input/output sources to work with the system tests.TEST_CONSOLE=1
only works with this build tag now.the test tag also replaces the EFF wordlist with a predictable 'a a a a' to reduce complexity in the test script and make debugging easier.
package dependencies for the old implementation and test console have been removed.
there is a new file at
/var/snap/microcloud/common/test-output
that is generated with the test build tag andTEST_CONSOLE=1
to show how each question interpreted the pre-defined input.