Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(field): remove bold prefix for error/caution/success validation #1063

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

lorumic
Copy link
Contributor

@lorumic lorumic commented Apr 4, 2024

Done

  • Removed bold "Error:"/"Caution:"/"Success:" prefix in input field validation message.

QA

Storybook

To see rendered examples of all react-components, run:

yarn start

QA in your project

from react-components run:

yarn build
npm pack

Install the resulting tarball in your project with:

yarn add <path-to-tarball>

QA steps

  • Go to Input page in storybook.
  • Check examples for Error/Success/Caution. There should be no bold prefix before the message itself.

@webteam-app
Copy link

@aaryanporwal
Copy link
Contributor

Can I get invite to join Percy organization? cc: @bartaz

@bartaz
Copy link
Member

bartaz commented Apr 5, 2024

Can I get invite to join Percy organization? cc: @bartaz

Sent

@lorumic lorumic merged commit ef320d9 into canonical:main Apr 5, 2024
8 of 13 checks passed
@lorumic lorumic deleted the remove-validation-prefix branch April 5, 2024 16:38
@lorumic
Copy link
Contributor Author

lorumic commented Apr 5, 2024

Thanks @aaryanporwal for the Percy review!

Copy link

github-actions bot commented Apr 5, 2024

🎉 This PR is included in version 0.51.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants