Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update to Storybook 8 #1081

Merged
merged 8 commits into from
Jul 5, 2024

Conversation

huwshimi
Copy link
Collaborator

@huwshimi huwshimi commented May 10, 2024

Done

QA

Storybook

To see rendered examples of all react-components, run:

yarn start

QA in your project

from react-components run:

yarn build
npm pack

Install the resulting tarball in your project with:

yarn add <path-to-tarball>

QA steps

  • Go through and check that component docs look OK.

@webteam-app
Copy link

Copy link
Contributor

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spot checking QA on the demo server seems fine.
I didn't manage to check all the individual components. I guess those are mostly 1:1 transitions from mdx to tsx. Thanks for this massive update!

package.json Show resolved Hide resolved
src/docs/getting-started.stories.mdx Outdated Show resolved Hide resolved
Copy link
Contributor

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am surprised all screenshots in percy are marked as "new"?
Also this one seems to be not all right:
image

@huwshimi
Copy link
Collaborator Author

huwshimi commented Jul 2, 2024

I am surprised all screenshots in percy are marked as "new"?

I think this is because the Storybook URL scheme has changed.

Also this one seems to be not all right:

Every time I run it a different set of images fail with that error. I'll try again later when hopefully the server is more stable.

@huwshimi
Copy link
Collaborator Author

huwshimi commented Jul 2, 2024

I tried upgrading to the latest percy and storybook, but that didn't fix it.

@huwshimi huwshimi force-pushed the upgrade-storybook-v8 branch 2 times, most recently from 6323a20 to 648b814 Compare July 4, 2024 00:41
@huwshimi
Copy link
Collaborator Author

huwshimi commented Jul 4, 2024

@edlerd I've increased the asset loading timeouts in CircleCI and now the snapshots are all working.

Copy link
Contributor

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tinny nitpick below.
It might be better to stash the commits into a single one?

.percy.yml Outdated
network-idle-timeout: 700
retry: true
launch-options:
timeout: 60000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
timeout: 60000
timeout: 60000

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Fixed.

@huwshimi huwshimi merged commit 9668ce6 into canonical:main Jul 5, 2024
9 checks passed
Copy link

🎉 This PR is included in version 0.59.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code Snippet Content Iframe shows 404 on production
3 participants