-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update to Storybook 8 #1081
Conversation
c834be3
to
ff70dcf
Compare
ff70dcf
to
002b7f2
Compare
002b7f2
to
04e8128
Compare
04e8128
to
a23dc11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spot checking QA on the demo server seems fine.
I didn't manage to check all the individual components. I guess those are mostly 1:1 transitions from mdx to tsx. Thanks for this massive update!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is because the Storybook URL scheme has changed.
Every time I run it a different set of images fail with that error. I'll try again later when hopefully the server is more stable. |
I tried upgrading to the latest percy and storybook, but that didn't fix it. |
6323a20
to
648b814
Compare
648b814
to
3021b1f
Compare
4d0fc43
to
a3c8a01
Compare
@edlerd I've increased the asset loading timeouts in CircleCI and now the snapshots are all working. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tinny nitpick below.
It might be better to stash the commits into a single one?
.percy.yml
Outdated
network-idle-timeout: 700 | ||
retry: true | ||
launch-options: | ||
timeout: 60000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
timeout: 60000 | |
timeout: 60000 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Fixed.
🎉 This PR is included in version 0.59.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Done
QA
Storybook
To see rendered examples of all react-components, run:
QA in your project
from
react-components
run:Install the resulting tarball in your project with:
QA steps