Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update to Storybook 8 #1081

Merged
merged 8 commits into from
Jul 5, 2024
Merged

chore(deps): update to Storybook 8 #1081

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
54a4ac3
chore(deps): update to Storybook 8
huwshimi May 10, 2024
c69f612
fix: fix cypress url
huwshimi May 12, 2024
3192ead
fix: commit ignored docs file
huwshimi Jun 30, 2024
375d4d1
deps: upgrade storybook and percy
huwshimi Jul 2, 2024
3021b1f
ci: increase the asset timeout
huwshimi Jul 4, 2024
a3c8a01
fix: use relative path for iframe.
huwshimi Jul 4, 2024
e9738d3
ci: increase timeout
huwshimi Jul 4, 2024
4432258
fix: new line
huwshimi Jul 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
node_modules
dist
docs
.env.local
.DS_Store
.idea
Expand All @@ -15,6 +14,7 @@ yarn-error.log*

storybook-static/
*.fuse*
*.nfs*

cypress/screenshots/
cypress/videos
Expand Down
5 changes: 5 additions & 0 deletions .percy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,8 @@ version: 2
snapshot:
widths: [1280]
enable-javascript: true
discovery:
network-idle-timeout: 700
retry: true
launch-options:
timeout: 60000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
timeout: 60000
timeout: 60000

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Fixed.

7 changes: 2 additions & 5 deletions .storybook/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
const path = require("path");

const config = {
stories: ["../src/**/*.stories.@(js|ts|jsx|tsx|mdx)"],
stories: ["../src/**/*.@(mdx|stories.@(js|ts|jsx|tsx))"],
addons: [
"@storybook/addon-essentials",
"@storybook/addon-docs",
"@storybook/addon-controls",
"@storybook/addon-a11y",
"@storybook/addon-mdx-gfm",
"@storybook/addon-webpack5-compiler-babel"
],
webpackFinal: async (config) => {
config.module.rules.push({
Expand All @@ -24,9 +24,6 @@ const config = {
name: "@storybook/react-webpack5",
options: {},
},
features: {
storyStoreV7: false,
},
};

export default config;
2 changes: 1 addition & 1 deletion .storybook/manager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { addons } from "@storybook/addons";
import { addons } from '@storybook/manager-api';
import vanillaish from "./vanillaish";

addons.setConfig({
Expand Down
4 changes: 2 additions & 2 deletions cypress/support/commands.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,10 @@ import "@testing-library/cypress/add-commands";
* @param { string } variant - variant of component, e.g. "Highlighted"
*/
Cypress.Commands.add("visitPage", (page, variant) => {
const baseUrl = `http://localhost:${Cypress.env("port")}/iframe.html?id=`;
const baseUrl = `http://localhost:${Cypress.env("port")}/iframe.html?id=components-`;
if (variant) {
cy.visit(`${baseUrl}${page.toLowerCase()}--${variant.toLowerCase()}`);
} else {
cy.visit(`${baseUrl}${page.toLowerCase()}--default-story`);
cy.visit(`${baseUrl}${page.toLowerCase()}--default`);
}
});
26 changes: 13 additions & 13 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,19 +28,19 @@
"@babel/cli": "7.24.5",
"@babel/eslint-parser": "7.24.5",
"@babel/preset-typescript": "7.24.1",
"@percy/cli": "1.28.5",
"@percy/storybook": "5.0.3",
"@percy/cli": "1.28.8",
"@percy/storybook": "6.0.0",
"@semantic-release/changelog": "6.0.3",
"@semantic-release/git": "10.0.1",
"@storybook/addon-a11y": "7.6.19",
"@storybook/addon-essentials": "7.6.19",
"@storybook/addon-interactions": "7.6.19",
"@storybook/addon-links": "7.6.19",
"@storybook/addon-mdx-gfm": "7.6.19",
"@storybook/addon-onboarding": "1.0.11",
"@storybook/blocks": "7.6.19",
"@storybook/react": "7.6.19",
"@storybook/react-webpack5": "7.6.19",
"@storybook/addon-a11y": "8.1.11",
"@storybook/addon-essentials": "8.1.11",
"@storybook/addon-interactions": "8.1.11",
"@storybook/addon-links": "8.1.11",
"@storybook/addon-onboarding": "8.1.11",
"@storybook/addon-webpack5-compiler-babel": "3.0.3",
"@storybook/blocks": "8.1.11",
"@storybook/react": "8.1.11",
"@storybook/react-webpack5": "8.1.11",
"@testing-library/cypress": "10.0.1",
"@testing-library/dom": "10.1.0",
"@testing-library/jest-dom": "6.4.5",
Expand Down Expand Up @@ -79,7 +79,7 @@
"sass": "1.77.0",
"sass-loader": "14.2.1",
"semantic-release": "23.0.8",
"storybook": "7.6.19",
"storybook": "8.1.11",
"style-loader": "4.0.0",
"stylelint": "16.5.0",
"stylelint-config-prettier": "9.0.5",
Expand Down Expand Up @@ -110,7 +110,7 @@
"@types/react": "18.3.1",
"@types/react-dom": "18.3.0",
"postcss": "^8.3.11",
"jackspeak": "2.3.6"
"jackspeak": "2.1.1"
edlerd marked this conversation as resolved.
Show resolved Hide resolved
},
"peerDependencies": {
"@types/react": "^17.0.2 || ^18.0.0",
Expand Down
244 changes: 0 additions & 244 deletions src/components/Accordion/Accordion.stories.mdx
View file
Open in desktop

This file was deleted.

Loading
Loading