build: pin jsonschema to >4, <4.18 to avoid installing 4.18.x #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because some dependencies of jsonschema now require the rust toolchain (see 1 and 2), building charms that depend on SDI (and therefore pull jsonschema) fail when building because none of them have rustc available when pip installing the charm's python dependencies. Reasoning: jsonschema 4.18.x introduced a dependency on rdps-py which at the same time introduced a dependency on maturin, a python package that requires the rustc toolchain to be built and installed from source. jsonschema 4.17.x does not have that dependency. Links: [1]python-jsonschema/jsonschema#1117 [2] python-jsonschema/jsonschema#1114 Partially fixes: canonical/bundle-kubeflow#648
addyess
requested changes
Jul 25, 2023
Co-authored-by: Adam Dyess <adam.dyess@canonical.com>
addyess
approved these changes
Jul 25, 2023
ca-scribner
reviewed
Jul 25, 2023
DnPlas
changed the title
|
🚀 |
DnPlas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because some dependencies of jsonschema now require the rust toolchain (see 1 and 2), building charms that depend on SDI (and therefore pull jsonschema) fail when building because none of them have rustc available when pip installing the charm's python dependencies.
Reasoning:
jsonschema 4.18.x introduced a dependency on rdps-py which at the same time introduced a dependency on maturin, a python package that requires the rustc toolchain to be built and installed from source. jsonschema 4.17.x does not have that dependency.
Merge after #50
Links:
[1]python-jsonschema/jsonschema#1117
[2] python-jsonschema/jsonschema#1114
Part of: canonical/bundle-kubeflow#648