Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: pin jsonschema to >4, <4.18 to avoid installing 4.18.x #49

Merged
merged 4 commits into from
Jul 25, 2023
Merged

build: pin jsonschema to >4, <4.18 to avoid installing 4.18.x #49

merged 4 commits into from
Jul 25, 2023

Commits on Jul 25, 2023

  1. build: pin jsonschema to ^4.17.3 to avoid installing 4.18.x 

    Because some dependencies of jsonschema now require the rust toolchain (see 1 and 2), building
charms that depend on SDI (and therefore pull jsonschema) fail when building because none
of them have rustc available when pip installing the charm's python dependencies.

Reasoning:
jsonschema 4.18.x introduced a dependency on rdps-py which at the same time introduced
a dependency on maturin, a python package that requires the rustc toolchain to be
built and installed from source. jsonschema 4.17.x does not have that dependency.

Links:
[1]python-jsonschema/jsonschema#1117
[2] python-jsonschema/jsonschema#1114

Partially fixes: canonical/bundle-kubeflow#648
    @DnPlas
    DnPlas committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    1191606 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into dnplas-pin-jsonschema

    @ca-scribner
    ca-scribner authored Jul 25, 2023
    Configuration menu
    Copy the full SHA
    b7c9de1 View commit details
    Browse the repository at this point in the history

  3. [skip] use wildcard instead of fix ver 

    Co-authored-by: Adam Dyess <adam.dyess@canonical.com>
    @DnPlas @addyess
    DnPlas and addyess authored Jul 25, 2023
    Configuration menu
    Copy the full SHA
    8df3af4 View commit details
    Browse the repository at this point in the history

  4. [skip] use another range for jsonschema

    @DnPlas
    DnPlas committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    3f5ccc2 View commit details
    Browse the repository at this point in the history