Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: /kubernetes/compare redesign #14660

Merged
merged 4 commits into from
Jan 23, 2025

Conversation

mtruj013
Copy link
Contributor

@mtruj013 mtruj013 commented Jan 17, 2025

Done

QA

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-12877

@webteam-app
Copy link

@mtruj013 mtruj013 changed the title Apply redesign feat: /kubernetes/compare redesign Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.58%. Comparing base (cab1ea7) to head (64adde8).
Report is 2182 commits behind head on k8s-bubble-refresh.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           k8s-bubble-refresh   #14660      +/-   ##
======================================================
- Coverage               74.46%   72.58%   -1.89%     
======================================================
  Files                     107      120      +13     
  Lines                    2847     3392     +545     
  Branches                  948     1169     +221     
======================================================
+ Hits                     2120     2462     +342     
- Misses                    703      906     +203     
  Partials                   24       24              

see 35 files with indirect coverage changes

@mattea-turic
Copy link
Collaborator

mattea-turic commented Jan 20, 2025

thank youu @mtruj013, pretty much perfect!

just one tiny comment:

Table section:

  • Is it possible for the text "Some categories are rated out of 5 for easy comparison." at the bottom of the table, to add a muted hr above it? Right now it looks a little floaty, so having a hr (maybe even col-6) to anchor it might help.

@eliman11
Copy link

eliman11 commented Jan 20, 2025

Thanks @mtruj013! Just some comments on the copy:

  • Change "&" to "and" in "Automated updates & patches" and "Multi-cloud deployments & operations" - also noted the changes in the copydoc
  • In the table, under the "Multi-cloud deployments" row I think the input fields should be formatted "5*" instead of "5/5*" based on the copydoc
  • Change to US spelling: Licence -> license in "Just count the number of physical or virtual machines you want support for and get coverage through Ubuntu Pro, without any additional licence or support fees." and "Predictable pricing model. No licence fees. Enterprise support."

Edit: Sorry I just checked how it looks on smaller screens and it seems to cut off the text that doesn't fit within the containers. Is it possible to wrap the text so we don't lose any content?
Screenshot 2025-01-20 at 10 47 09

Screenshot 2025-01-20 at 10 47 40

@eliman11
Copy link

Thanks for the quick changes @mtruj013, looks great! Just one comment - could you change & to "and" in the "Multi-cloud deployments & operations" heading as well? Super minor though so will add UX+1. Thanks!

@immortalcodes
Copy link
Member

immortalcodes commented Jan 22, 2025

image
image
Minor difference from design.
image
image

@immortalcodes
Copy link
Member

image
Inconsistent headings on medium screen in the table, for large screen the column name was "MicroK8s,
Charmed Kubernetes" if we were to change it we shall change it for all the rows.

Comment on lines +24 to +29
<div class="row--50-50">
<div class="col">
<h1>
Kubernetes
<br />
distributions comparison
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, did you try out hero_macro here?
https://vanillaframework.io/docs/patterns/hero

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but it doesn't have the option for 50/50 split with just text unfortunately

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ticket opened here

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ticket! I've raised a PR to implement a fix that supports 50/50 with no image.

data-form-location="/shared/forms/interactive/kubernetes"
data-form-id="3230"
data-lp-id="6274"
data-return-url="https://ubuntu.com/kubernetes/thank-you?product=kubernetes-compare"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may be wrong but are we not removing thank-you pages and replacing them with the #success tags.
Like this one https://ubuntu-com-14660.demos.haus/kubernetes/compare#success

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It actually routes to the banner as is but indeed probably better to explicit 🙂

<div class="row--50-50">
<hr class="p-rule--muted" />
<div class="col">
<h2>Multi-cloud deployments &amp; operations</h2>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be changed according to copydoc

Suggested change
<h2>Multi-cloud deployments &amp; operations</h2>
<h2>Multi-cloud deployments and operations</h2>

@mtruj013
Copy link
Contributor Author

mtruj013 commented Jan 22, 2025

Thanks @immortalcodes! Could you have another look? I applied all changes except the one suggested in this first screenshot as anchoring the text with a col-6 hr was requested during design review

@immortalcodes
Copy link
Member

LGTM! Nice work 🎆

@mtruj013 mtruj013 merged commit b2bf078 into canonical:k8s-bubble-refresh Jan 23, 2025
14 of 15 checks passed
@mtruj013 mtruj013 deleted the k8s-compared branch January 23, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants