Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hero): 50/50 with no image is laid out in split columns #5450

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

jmuzina
Copy link
Member

@jmuzina jmuzina commented Jan 22, 2025

Done

  • Adjusts the hero pattern to split its left and right columns when layout="50/50" and no image is provided.
  • Drive-by: removes docs section new/updated status labels for changes that were made several months ago.

No API changes have been made.

Fixes #5449
Fixes WD-18357

QA

Check if PR is ready for release

If this PR contains Vanilla SCSS or macro code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention
    • if existing APIs (CSS classes & macro APIs) are not changed it can be a bugfix release (x.x.X)
    • if existing APIs (CSS classes & macro APIs) are changed/added/removed it should be a minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) or macros should be listed on the what's new page.

Screenshots

Screenshot from 2025-01-22 17-44-38
Screenshot from 2025-01-22 17-44-28
Screenshot from 2025-01-22 17-44-14

@webteam-app
Copy link

@jmuzina jmuzina added Review: Percy needed This PR needs a review of Percy for visual regressions Review: Percy +1 and removed Review: Percy needed This PR needs a review of Percy for visual regressions labels Jan 22, 2025
@jmuzina jmuzina marked this pull request as ready for review January 22, 2025 23:04
Copy link
Contributor

@mtruj013 mtruj013 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this @jmuzina !

@jmuzina jmuzina merged commit 20b8308 into canonical:main Jan 23, 2025
12 checks passed
@jmuzina jmuzina deleted the WD-18357-hero-50-50-text branch January 23, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hero pattern missing 50/50 split for text only
4 participants