[WIP] Integrate outlier sale overrides into the model #417
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the addition of manual analyst sale validation, we are updating the ingest here to preference outlier status based off of analyst determination.
I believe this PR updates all of the relevant functional fields. However, it is worth flagging the model report component of these refs. This ties into a larger question of how we want to handle the
sv_outlier_reason$nin model reporting in the future, given that they no longer tell the whole story given the analyst review addition.For example, if the
is_outlierfield istruebased on aflag_overridecolumn, there will be correspondingsv_outlier_reasoncolumns linked to that doc no, but they aren't the deterministic fields used in the calculation of theis_outlierin theflag_overridecase.It probably also makes sense to consider changing the broader architecture of column organization. I'm thinking these questions probably makes sense for a separate issue, but I'm curious to hear thoughts.