Update training data with reviewed sales #433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeancochrane
commented
Feb 3, 2026
Comment on lines
+574
to
+575
| - path: | ||
| output/performance_quantile/model_performance_quantile_assessment.parquet |
Member
Author
There was a problem hiding this comment.
I'm not sure why this line and the two diffed lines below it got split onto multiple lines. I assume something about the dvc version in my virtualenv is different and has different standards for line length. I can investigate further if it would be helpful, but I figured it wasn't a big deal and so wasn't worth looking into in detail.
jeancochrane
deleted the
jeancochrane/update-training-data-with-reviewed-sales
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reruns the ingest, pushes input data to DVC, and updates the lockfile to point to it so that we can run models using the new reviewed sales that we added in #427.
I tested this by running a model in Batch.