Issue 796: remove days of the week from human readable description when the whole week is specified #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en the whole week is specified
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #797 +/- ##
==========================================
+ Coverage 86.89% 86.92% +0.02%
==========================================
Files 32 32
Lines 931 933 +2
Branches 124 124
==========================================
+ Hits 809 811 +2
Misses 103 103
Partials 19 19 ☔ View full report in Codecov by Sentry. |
|
Nice |
alexandre-paroissien
approved these changes
Aug 28, 2024
auvipy
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example from the issue #796
Before (2.6.0): "At 01:00 AM UTC"
After (2.7.0): "At 01:00 AM, only on Sunday, Monday, Tuesday, Wednesday, Thursday, Friday, and Saturday UTC"
This PR return the previous behaviour in case all days of the week are specified:
0 2 * * *->"At 02:00 AM UTC"