Skip to content

Conversation

@MehrazRumman
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.50%. Comparing base (a0175b0) to head (ea52094).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2219   +/-   ##
=======================================
  Coverage   81.50%   81.50%           
=======================================
  Files          77       77           
  Lines        9524     9524           
  Branches     1152     1152           
=======================================
  Hits         7763     7763           
  Misses       1569     1569           
  Partials      192      192           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MehrazRumman
Copy link
Contributor Author

@auvipy can you review this PR ?

experimental: [false]
include:
- python-version: pypy3.10
toxenv: 'py-amqp'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this part have to be removed? Can you explain please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes , I think pypy3.10 is required here for make certain workloads faster. I will undo the change .

@auvipy
Copy link
Member

auvipy commented Jan 10, 2025

You should check why integration tests are failing on pypy. Do protobuf work with pypy? If not you can skip pypy for grpc

@auvipy
Copy link
Member

auvipy commented Feb 5, 2025

#2240

@Nusnus Nusnus marked this pull request as draft February 17, 2025 22:20
@auvipy
Copy link
Member

auvipy commented May 12, 2025

can you please revisit this?

@auvipy auvipy added this to the 5.7.0 milestone May 12, 2025
Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please update the dependencies? we have updated them in main branch so need sync

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants